lib: cockpit: drop old Mozilla window.location.hash hack

Firefox used to give a different value depending on the location hash
when using `window.location.hash` and `window.location.href` with for
example `#abc%21abc`. This is now fixed and in all browsers the
following is always true:

window.location.hash.slice(1) == window.location.href.split('#')[1]

Which proves this is now fixed in Firefox.

Author: jelly

pkg/lib/cockpit.js

@@ -1119,18 +1119,8 @@ function factory() {
      * Cockpit location
      */
 
-    /* HACK: Mozilla will unescape 'window.location.hash' before returning
-     * it, which is broken.
-     *
-     * https://bugzilla.mozilla.org/show_bug.cgi?id=135309
-     */
-
     let last_loc = null;
 
-    function get_window_location_hash() {
-        return (window.location.href.split('#')[1] || '');
-    }
-
     function Location() {
         const self = this;
         const application = cockpit.transport.application();
@@ -1145,7 +1135,7 @@ function factory() {
             self.url_root = self.url_root + application.replace("cockpit+", '');
         }
 
-        const href = get_window_location_hash();
+        const href = window.location.hash.slice(1);
         const options = { };
         self.path = decode(href, options);
 
@@ -1308,7 +1298,7 @@ function factory() {
     Object.defineProperty(cockpit, "location", {
         enumerable: true,
         get: function() {
-            if (!last_loc || last_loc.href !== get_window_location_hash())
+            if (!last_loc || last_loc.href !== window.location.hash.slice(1))
                 last_loc = new Location();
             return last_loc;
         },
@@ -1319,9 +1309,7 @@ function factory() {
 
     window.addEventListener("hashchange", function() {
         last_loc = null;
-        let hash = window.location.hash;
-        if (hash.indexOf("#") === 0)
-            hash = hash.substring(1);
+        const hash = window.location.hash.slice(1);
         cockpit.hint("location", { hash });
         cockpit.dispatchEvent("locationchanged");
     });