Skip to content

Commit 34cffc1

Browse files
tomasmatusjelly
authored andcommitted
workflows: add py3.6 to tox workflow, drop py3.8
Tox workflow is missing py3.6 and py3.8. Py3.6 can be installed but py3.8 is no longer available so I propose we drop it. As per tox FAQ we need to set `requires = virtualenv<20.22.0` as never virtualenv version dropped support for version <=py3.6. https://tox.wiki/en/latest/faq.html#testing-end-of-life-python-versions
1 parent afea5fe commit 34cffc1

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

.github/workflows/tox.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ jobs:
1919
steps:
2020
- name: Install tox dependencies
2121
run: |
22-
dnf install -y git-core tox util-linux
22+
dnf install -y git-core tox util-linux python3.6
2323
useradd tox
2424
2525
# https://github.blog/2022-04-12-git-security-vulnerability-announced/

pyproject.toml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -197,8 +197,9 @@ legacy_tox_ini = """
197197
[tox]
198198
envlist = lint,pytest
199199
isolated_build = True
200+
requires = virtualenv<20.22.0
200201
labels =
201-
venv = py3{6,8,9,10,11,12,13}-pytest
202+
venv = py3{6,9,10,11,12,13}-pytest
202203
203204
# The default test environments use system packages and never PyPI.
204205
[testenv:{lint,pytest}]

0 commit comments

Comments
 (0)