Skip to content

Commit f6e373e

Browse files
committed
fix
1 parent 1fd4251 commit f6e373e

File tree

18 files changed

+328
-248
lines changed

18 files changed

+328
-248
lines changed

.github/workflows/release.yml

Lines changed: 26 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -2,34 +2,34 @@ name: packaging
22

33
on:
44
workflow_run:
5-
workflows: [pre-checks]
6-
types:
7-
- completed
5+
workflows: [pre-checks]
6+
types:
7+
- completed
88

99
jobs:
10-
packaging:
11-
if: ${{ github.ref_name == 'main' && github.event.workflow_run.conclusion == 'success' }}
12-
runs-on: ubuntu-latest
10+
packaging:
11+
if:
12+
${{ github.ref_name == 'main' &&
13+
github.event.workflow_run.conclusion == 'success' }}
14+
runs-on: ubuntu-latest
1315

14-
steps:
15-
- name: Checkout
16-
uses: actions/checkout@v3
17-
with:
18-
fetch-depth: 0
19-
token: ${{ secrets.GH_TOKEN }}
20-
21-
- name: Setup Node.js
22-
uses: actions/setup-node@v3
23-
with:
24-
node-version: 18
16+
steps:
17+
- name: Checkout
18+
uses: actions/checkout@v3
19+
with:
20+
fetch-depth: 0
21+
token: ${{ secrets.GH_TOKEN }}
2522

26-
- name: Install dependencies
27-
run: |
28-
npm ci
23+
- name: Setup Node.js
24+
uses: actions/setup-node@v3
25+
with:
26+
node-version: 18
2927

30-
- name: Release
31-
run: npx semantic-release
32-
env:
33-
GH_TOKEN: ${{ secrets.GH_TOKEN }}
34-
35-
28+
- name: Install dependencies
29+
run: |
30+
npm ci
31+
32+
- name: Release
33+
run: npx semantic-release
34+
env:
35+
GH_TOKEN: ${{ secrets.GH_TOKEN }}

.github/workflows/tests.yml

Lines changed: 24 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -4,27 +4,27 @@ on: [push]
44

55
jobs:
66
pre-checks:
7-
runs-on: ubuntu-latest
8-
timeout-minutes: 5
9-
10-
steps:
11-
- uses: actions/checkout@v3
12-
13-
- name: Setup Node.js
14-
uses: actions/setup-node@v3
15-
with:
16-
node-version: 18
17-
18-
- name: Install dependencies
19-
run: |
20-
npm ci
21-
22-
- name: Format
23-
run: |
24-
npm run format
25-
26-
- name: Format
27-
run: |
28-
npm run lint
29-
30-
# put test run step here...
7+
runs-on: ubuntu-latest
8+
timeout-minutes: 5
9+
10+
steps:
11+
- uses: actions/checkout@v3
12+
13+
- name: Setup Node.js
14+
uses: actions/setup-node@v3
15+
with:
16+
node-version: 18
17+
18+
- name: Install dependencies
19+
run: |
20+
npm ci
21+
22+
- name: Format
23+
run: |
24+
npm run format
25+
26+
- name: Format
27+
run: |
28+
npm run lint
29+
30+
# put test run step here...

CONTRIBUTE.md

Lines changed: 65 additions & 42 deletions
Original file line numberDiff line numberDiff line change
@@ -1,27 +1,34 @@
11
# Contributing to Session Storage Hub
22

3-
- [Question or Problem?](#question)
4-
- [Issues and Bugs](#issue)
5-
- [Feature Requests](#feature)
6-
- [Submission Guidelines](#submitting-an-issue)
7-
- [Coding Rules](#coding-rules)
8-
- [Commit Message Guidelines](#commits)
3+
- [Question or Problem?](#question)
4+
- [Issues and Bugs](#issue)
5+
- [Feature Requests](#feature)
6+
- [Submission Guidelines](#submitting-an-issue)
7+
- [Coding Rules](#coding-rules)
8+
- [Commit Message Guidelines](#commits)
99

1010
## Question
1111

12-
Do not open an issue without first checking the [discussion](https://github.com/cmolisee/session-storage-hub/discussions) forums and starting a new post.
12+
Do not open an issue without first checking the
13+
[discussion](https://github.com/cmolisee/session-storage-hub/discussions) forums
14+
and starting a new post.
1315

1416
## Issue
1517

16-
If you find a bug in the source code, you can help us by starting a new post in the [discussion](https://github.com/cmolisee/session-storage-hub/discussions) forum and submitting a new issue.
18+
If you find a bug in the source code, you can help us by starting a new post in
19+
the [discussion](https://github.com/cmolisee/session-storage-hub/discussions)
20+
forum and submitting a new issue.
1721

18-
Please link the discussion post in the body of the issue and provide sufficient information:
19-
- how was the issue discovered
20-
- how to replciate the issue
22+
Please link the discussion post in the body of the issue and provide sufficient
23+
information:
24+
25+
- how was the issue discovered
26+
- how to replciate the issue
2127

2228
## Feature
2329

24-
You can *request* a new feature by starting a [discussion](https://github.com/cmolisee/session-storage-hub/discussions).
30+
You can _request_ a new feature by starting a
31+
[discussion](https://github.com/cmolisee/session-storage-hub/discussions).
2532

2633
It should include all pertinent information on the proposal.
2734

@@ -33,45 +40,59 @@ Under Construction
3340

3441
Before you submit your Pull Request (PR) consider the following guidelines:
3542

36-
1. Search [GitHub](https://github.com/cmolisee/session-storage-hub/pulls) for an open or closed PR that relates to your submission.
37-
You don't want to duplicate existing efforts.
43+
1. Search [GitHub](https://github.com/cmolisee/session-storage-hub/pulls) for an
44+
open or closed PR that relates to your submission. You don't want to
45+
duplicate existing efforts.
3846

39-
2. Be sure that an issue describes the problem you're fixing, or documents the design for the feature you'd like to add.
40-
Discussing the design upfront helps to ensure that we're ready to accept your work.
47+
2. Be sure that an issue describes the problem you're fixing, or documents the
48+
design for the feature you'd like to add. Discussing the design upfront helps
49+
to ensure that we're ready to accept your work.
4150

42-
3. [Fork](https://docs.github.com/en/github/getting-started-with-github/fork-a-repo) the angular/angular repo.
51+
3. [Fork](https://docs.github.com/en/github/getting-started-with-github/fork-a-repo)
52+
the angular/angular repo.
4353

4454
4. In your forked repository, make your changes in a new git branch:
4555

46-
```shell
47-
git checkout -b my-fix-branch main
48-
```
56+
```shell
57+
git checkout -b my-fix-branch main
58+
```
4959

50-
5. Create your patch, **including appropriate test cases** (NOT CURRENTLY REQUIRED. NO TESTS IMPLEMENTED AS OF 10/08/23). You must ensure your code is linted, formatted, and builds. It is also necessary to ensure you thoroughly smoke and regression test in the browser.
60+
5. Create your patch, **including appropriate test cases** (NOT CURRENTLY
61+
REQUIRED. NO TESTS IMPLEMENTED AS OF 10/08/23). You must ensure your code is
62+
linted, formatted, and builds. It is also necessary to ensure you thoroughly
63+
smoke and regression test in the browser.
5164

5265
6. Follow our [Coding Rules](#rules).
5366

54-
7. You should make small and descriptive commits throughout development. Release notes and versioning is handled automatically based on commits.
67+
7. You should make small and descriptive commits throughout development. Release
68+
notes and versioning is handled automatically based on commits.
5569

5670
8. Push your branch to GitHub.
5771

5872
9. In GitHub, send a pull request to `main`.
5973

6074
### Reviewing a Pull Request
6175

62-
Your Pull Request must be reviewed and approved before it can be merged. There is no garuntee that your PR will be approved and/or merged. There may be additional requirements or requests before the PR is accepted, approved, and/or merged.
76+
Your Pull Request must be reviewed and approved before it can be merged. There
77+
is no garuntee that your PR will be approved and/or merged. There may be
78+
additional requirements or requests before the PR is accepted, approved, and/or
79+
merged.
6380

6481
#### After your pull request is merged
6582

66-
After your pull request is merged, you can safely delete your branch and pull the changes from the main (upstream) repository.
67-
Your branch will automatically be deleted in the origin.
83+
After your pull request is merged, you can safely delete your branch and pull
84+
the changes from the main (upstream) repository. Your branch will automatically
85+
be deleted in the origin.
6886

6987
## Coding Rules
70-
To ensure consistency throughout the source code, keep these rules in mind as you are working:
7188

72-
* Test your changes.
73-
* Document your code.
74-
* Avoid hard to read code, nested blocks more than 4 levels, obscure code, inefficient code.
89+
To ensure consistency throughout the source code, keep these rules in mind as
90+
you are working:
91+
92+
- Test your changes.
93+
- Document your code.
94+
- Avoid hard to read code, nested blocks more than 4 levels, obscure code,
95+
inefficient code.
7596

7697
## Commits
7798

@@ -89,26 +110,28 @@ To ensure consistency throughout the source code, keep these rules in mind as yo
89110
└─⫸ Commit Type: build|ci|docs|feat|fix|perf|refactor|test
90111
```
91112

92-
The `<type>` and `<summary>` fields are mandatory, the `(<scope>)` field is optional.
93-
113+
The `<type>` and `<summary>` fields are mandatory, the `(<scope>)` field is
114+
optional.
94115

95116
##### Type
96117

97118
Must be one of the following (we use the same conventions as angular):
98119

99-
* **build**: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
100-
* **ci**: Changes to our CI configuration files and scripts (examples: CircleCi, SauceLabs)
101-
* **docs**: Documentation only changes
102-
* **feat**: A new feature
103-
* **fix**: A bug fix
104-
* **perf**: A code change that improves performance
105-
* **refactor**: A code change that neither fixes a bug nor adds a feature
106-
* **test**: Adding missing tests or correcting existing tests
120+
- **build**: Changes that affect the build system or external dependencies
121+
(example scopes: gulp, broccoli, npm)
122+
- **ci**: Changes to our CI configuration files and scripts (examples:
123+
CircleCi, SauceLabs)
124+
- **docs**: Documentation only changes
125+
- **feat**: A new feature
126+
- **fix**: A bug fix
127+
- **perf**: A code change that improves performance
128+
- **refactor**: A code change that neither fixes a bug nor adds a feature
129+
- **test**: Adding missing tests or correcting existing tests
107130

108131
##### Summary
109132

110133
Use the summary field to provide a succinct description of the change:
111134

112-
* all lowercase.
113-
* present tense.
114-
* concise.
135+
- all lowercase.
136+
- present tense.
137+
- concise.

README.md

Lines changed: 48 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -34,46 +34,64 @@
3434

3535
## Documentation
3636

37-
- [Installation](#installation)
38-
- [Architecture](#architecture)
39-
- [Issues](#issues)
40-
- [Releases](https://github.com/cmolisee/session-storage-hub/releases)
41-
- [Contributing](#contributing)
37+
- [Installation](#installation)
38+
- [Architecture](#architecture)
39+
- [Issues](#issues)
40+
- [Releases](https://github.com/cmolisee/session-storage-hub/releases)
41+
- [Contributing](#contributing)
4242

4343
## Installation
4444

4545
### Via Github and Terminal
4646

47-
1. In your terminal pull the 'main' branch to your local in a location of your choice (i.e. 'Documents').
47+
1. In your terminal pull the 'main' branch to your local in a location of your
48+
choice (i.e. 'Documents').
49+
4850
```
4951
git clone https://github.com/cmolisee/session-storage-hub.git
5052
```
51-
2. Change directory to the location you cloned the repo in and install dependencies.
53+
54+
2. Change directory to the location you cloned the repo in and install
55+
dependencies.
56+
5257
```
5358
cd <location>
5459
npm i
5560
```
61+
5662
3. Build the project.
63+
5764
```
5865
npm run build
5966
```
67+
6068
4. Open your chrome browser and open the extension manager.
6169
5. Turn on `Developer Mode` and select `Load upacked`.
62-
6. Select the build folder in the location you built the project. You may need to restart the browser and/or reload tabs.
70+
6. Select the build folder in the location you built the project. You may need
71+
to restart the browser and/or reload tabs.
6372

6473
### Via Release Artifacts
6574

66-
1. Go to the [Releases](https://github.com/cmolisee/session-storage-hub/releases) page and download the Source Code .zip file from the latest release.
67-
2. Unpack the .zip file into a location of your choice. It will include all source code including the pre-built latest version.
75+
1. Go to the
76+
[Releases](https://github.com/cmolisee/session-storage-hub/releases) page and
77+
download the Source Code .zip file from the latest release.
78+
2. Unpack the .zip file into a location of your choice. It will include all
79+
source code including the pre-built latest version.
6880
3. Open your chrome browser and open the extension manager.
6981
4. Turn on `Developer Mode` and select `Load upacked`.
70-
5. Select the build folder in the location you built the project. You may need to restart the browser and/or reload tabs.
82+
5. Select the build folder in the location you built the project. You may need
83+
to restart the browser and/or reload tabs.
7184

7285
### Upgrading
7386

74-
The extension will check for updates the first time you install or about every 5 hours since the last check. If a new version is available it will provide a link to the latest release at the bottom of the extenssion popup window. You can click on that link and follow the steps in the 'Release Artifacts' installation guide above.
87+
The extension will check for updates the first time you install or about every 5
88+
hours since the last check. If a new version is available it will provide a link
89+
to the latest release at the bottom of the extenssion popup window. You can
90+
click on that link and follow the steps in the 'Release Artifacts' installation
91+
guide above.
7592

76-
Alternatively, if you can follow 'Github and Terminal' installation and pull the latest version from main.
93+
Alternatively, if you can follow 'Github and Terminal' installation and pull the
94+
latest version from main.
7795

7896
### Basic Usage
7997

@@ -83,24 +101,35 @@ See the [usage](USAGE.md) documentation on how to use this extension.
83101

84102
This extension is built primarily with react, typescript, and sass.
85103

86-
Chrome api's are used extensively for browser, tab, and storage functionality and interaction.
104+
Chrome api's are used extensively for browser, tab, and storage functionality
105+
and interaction.
87106

88-
The extension injects a service worker ('background.js') via the manifest file to each webpage in order to read and write session storage data for each tab. Communication between the service worker and the extension is handled by the content script.
107+
The extension injects a service worker ('background.js') via the manifest file
108+
to each webpage in order to read and write session storage data for each tab.
109+
Communication between the service worker and the extension is handled by the
110+
content script.
89111

90112
All necessary files are minified and pacakged into the build folder.
91113

92114
## Issues
93115

94-
If you have questions, found a bug, or have an idea on a future additon you can start a [discussion](https://github.com/cmolisee/session-storage-hub/discussions).
116+
If you have questions, found a bug, or have an idea on a future additon you can
117+
start a
118+
[discussion](https://github.com/cmolisee/session-storage-hub/discussions).
95119

96120
## Releases
97121

98-
All releases including the latest release can be found [here](https://github.com/cmolisee/session-storage-hub/releases).
122+
All releases including the latest release can be found
123+
[here](https://github.com/cmolisee/session-storage-hub/releases).
99124

100125
## Contributing
101126

102-
Read through our [contributing guidelines](CONTRIBUTE.md) to learn about our submission process, coding conventions, and other information.
127+
Read through our [contributing guidelines](CONTRIBUTE.md) to learn about our
128+
submission process, coding conventions, and other information.
103129

104130
## Want to Help or have a Suggestion?
105131

106-
To report a bug or submit an idea for a future change? Read the [contribution guidelines](CONTRIBUTE.md), check out the repo issues section, or try the [Discussion Forum](https://github.com/cmolisee/session-storage-hub/discussions).
132+
To report a bug or submit an idea for a future change? Read the
133+
[contribution guidelines](CONTRIBUTE.md), check out the repo issues section, or
134+
try the
135+
[Discussion Forum](https://github.com/cmolisee/session-storage-hub/discussions).

0 commit comments

Comments
 (0)