BoringSSL changed its defaults in its commit google/boringssl@e748fac to now enable SSL_GROUP_X25519_MLKEM768 by default.
This however breaks Quiche's test suite.
As a stopgap, one can of course just disable ML-KEM in the test suite, e.g. by inserting
let curves = std::ffi::CString::new("X25519:P-256:P-384").unwrap();
bssl_sys::SSL_CTX_set1_curves_list(ctx_raw as *mut _, curves.as_ptr());
at https://github.com/cloudflare/quiche/blob/master/quiche/src/tls/mod.rs#L141, conditionally for tests only - but that's not super great, as it means the test suite runs without PQC coverage.
The problem is just that when changing that default, all the byte lengths of the ClientHello in various tests change, making the change rather involved. I would however suspect that a6c4dff might be changing the exact set of places that need updating from this?
BoringSSL changed its defaults in its commit google/boringssl@e748fac to now enable
SSL_GROUP_X25519_MLKEM768by default.This however breaks Quiche's test suite.
As a stopgap, one can of course just disable ML-KEM in the test suite, e.g. by inserting
at https://github.com/cloudflare/quiche/blob/master/quiche/src/tls/mod.rs#L141, conditionally for tests only - but that's not super great, as it means the test suite runs without PQC coverage.
The problem is just that when changing that default, all the byte lengths of the ClientHello in various tests change, making the change rather involved. I would however suspect that a6c4dff might be changing the exact set of places that need updating from this?