Skip to content

Commit 3e646de

Browse files
[ui-importer-modal] Bulk Edit column modal second iteration (#4165)
* Modal with data before starting new work header name changed but entire column vanishes Optimized code but with removing column bug Fixed mapping issue removed grey color Row data present as column values in sample values Fixed padding for the edit columns button WIP wip * nits left in first commit * Integrating the new api Before review comments First iteration of styling * Fixed styling issues * useLoadData hook used * LoadingErrorWrapper used * unit tests for the bulk edit columns * Fixing as part of review comments * Fixing 2 based on review comments * Merged properly * Linting fixed * Fixed the tests for editColumns * Removed loadingErrorWrapper * Fixing the linting issues * Updated the scss file * Revert "Removed loadingErrorWrapper" This reverts commit d49bf7d. * Removing all the errors after making changes in the previous commits * nits * Fixed faling unit tests * prettier errors fixed * Dropdown default string value in uppercase like other values * Based on review comments * resolve conflict * Fixed the errors after merge * Changes based on review comments * AI comments and suggestions updates * Review changes * Changes based on review comments * final review changes * Adding TODO * Fixed the unit tests * Removing unneccessary comments * Added the eslint statement that was removed mistakenly * Correcting tests * Unneccesary file * Removing all the unneccessary mocks and tests * Merging conflicts * fixing linting issues * Fixing post merging issues * Removing unneccessary scss file * fixing the test * changing the folder name to EditColumnsModal * Changes based on review comments * Fixing the style issues * Styling issues fixed * Adding aria-labels * Renaming to editableRows * Changes to the test in the filePreview * updating the test * Renaming * sql dialect changed * If error dont should table * test that EditColumnsModal is hidden before the the click and then that it is visible later * test that Edit Columns is visible and that it opens the dialog when clicked * Fixing the unit tests * clear error message * Tests optimized * Add basic validation for duplicate or empty column names * Changes acc to the review comments * testing for no sample data related cases * Fixing the border of the select dropdown * Fixing the padding of edit columns button * nits * Changing the error message * Final review changes * Fix unresolved GitHub conversation - clarify CSS selectors
1 parent 08480cc commit 3e646de

File tree

12 files changed

+879
-110
lines changed

12 files changed

+879
-110
lines changed

desktop/core/src/desktop/js/apps/admin/Components/utils.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,5 +18,6 @@ export const SERVER_LOGS_API_URL = '/api/v1/logs';
1818
export const CHECK_CONFIG_EXAMPLES_API_URL = '/api/v1/check_config';
1919
export const INSTALL_APP_EXAMPLES_API_URL = '/api/v1/install_app_examples';
2020
export const INSTALL_AVAILABLE_EXAMPLES_API_URL = '/api/v1/available_app_examples';
21+
export const SQL_TYPE_MAPPING_API_URL = '/api/v1/importer/sql_type_mapping';
2122
export const HUE_DOCS_CONFIG_URL = 'https://docs.gethue.com/administrator/configuration/';
2223
export const USAGE_ANALYTICS_API_URL = '/api/v1/usage_analytics';

desktop/core/src/desktop/js/apps/newimporter/FilePreviewTab/EditColumns/EditColumnsModal.tsx

Lines changed: 0 additions & 41 deletions
This file was deleted.

desktop/core/src/desktop/js/apps/newimporter/FilePreviewTab/EditColumns/EditColumns.scss renamed to desktop/core/src/desktop/js/apps/newimporter/FilePreviewTab/EditColumnsModal/EditColumnsModal.scss

Lines changed: 21 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,26 @@
1616

1717
@use 'variables' as vars;
1818

19-
.antd.cuix {
20-
.hue-importer-edit-columns {
21-
padding: vars.$fluidx-spacing-s;
19+
.hue-importer-edit-columns-modal {
20+
.ant-modal-content {
21+
width: 800px;
22+
}
23+
24+
&__input-title {
25+
width: 100px;
26+
}
27+
28+
&__type-select {
29+
width: 100px;
30+
31+
.ant-select-selector {
32+
border: 1px solid vars.$fluidx-gray-600;
33+
border-radius: vars.$border-radius-base;
34+
}
35+
}
36+
37+
&__no-sample {
38+
color: vars.$fluidx-gray-500;
39+
font-style: italic;
2240
}
2341
}

0 commit comments

Comments
 (0)