Skip to content

feat: fixed log config issue #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 18, 2025
Merged

feat: fixed log config issue #7

merged 2 commits into from
Jul 18, 2025

Conversation

AshutoshAM2002
Copy link
Contributor

what

  • Fixed log config attributes issue
  • Updated README file
  • Updated examples

@clouddrove-ci
Copy link
Member

Terraform Security Scan Failed

Show Output
Result #1 LOW Subnetwork does not have VPC flow logs enabled. 
────────────────────────────────────────────────────────────────────────────────
  main.tf:10-51
────────────────────────────────────────────────────────────────────────────────
   10resource "google_compute_subnetwork" "subnetwork" {
   11count = var.google_compute_subnetwork_enabled && var.module_enabled ? 1 : 0
   1213name    = module.labels.id
   14project = var.project_id
   15network = var.network
   16region  = var.gcp_region
   1718ipv6_access_type         = var.ipv6_access_type
   ..  
────────────────────────────────────────────────────────────────────────────────
          ID google-compute-enable-vpc-flow-logs
      Impact Limited auditing capability and awareness
  Resolution Enable VPC flow logs

  More Information
  - https://aquasecurity.github.io/tfsec/latest/checks/google/compute/enable-vpc-flow-logs/
  - https://registry.terraform.io/providers/hashicorp/google/latest/docs/resources/compute_subnetwork#enable_flow_logs
────────────────────────────────────────────────────────────────────────────────


  timings
  ──────────────────────────────────────────
  disk i/o             69.078µs
  parsing              90.26909ms
  adaptation           126.185µs
  checks               9.404843ms
  total                99.869196ms

  counts
  ──────────────────────────────────────────
  modules downloaded   0
  modules processed    1
  blocks processed     37
  files read           4

  results
  ──────────────────────────────────────────
  passed               0
  ignored              0
  critical             0
  high                 0
  medium               0
  low                  1

  1 potential problem(s) detected.

@clouddrove-ci
Copy link
Member

Terraform Security Scan Failed

Show Output
Result #1 LOW Subnetwork does not have VPC flow logs enabled. 
────────────────────────────────────────────────────────────────────────────────
  main.tf:10-51
────────────────────────────────────────────────────────────────────────────────
   10resource "google_compute_subnetwork" "subnetwork" {
   11count = var.google_compute_subnetwork_enabled && var.module_enabled ? 1 : 0
   1213name    = module.labels.id
   14project = var.project_id
   15network = var.network
   16region  = var.gcp_region
   1718ipv6_access_type         = var.ipv6_access_type
   ..  
────────────────────────────────────────────────────────────────────────────────
          ID google-compute-enable-vpc-flow-logs
      Impact Limited auditing capability and awareness
  Resolution Enable VPC flow logs

  More Information
  - https://aquasecurity.github.io/tfsec/latest/checks/google/compute/enable-vpc-flow-logs/
  - https://registry.terraform.io/providers/hashicorp/google/latest/docs/resources/compute_subnetwork#enable_flow_logs
────────────────────────────────────────────────────────────────────────────────


  timings
  ──────────────────────────────────────────
  disk i/o             70.902µs
  parsing              66.279235ms
  adaptation           131.134µs
  checks               5.409875ms
  total                71.891146ms

  counts
  ──────────────────────────────────────────
  modules downloaded   0
  modules processed    1
  blocks processed     37
  files read           4

  results
  ──────────────────────────────────────────
  passed               0
  ignored              0
  critical             0
  high                 0
  medium               0
  low                  1

  1 potential problem(s) detected.

@@ -0,0 +1,4 @@
output "id" {
value = module.subnet[*].id
description = "The ID of the s3 bucket."

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update description

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@Tanveer143s
Copy link

should u add subnet_private_access part in resource [for pvt subnet]

@Tanveer143s
Copy link

Tanveer143s commented Apr 23, 2024

routes part add in examples folder main.tf

working_directory: './example/basic'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Folder name should be examples not and example

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@Tanveer143s
Copy link

please update root readme module source-path correctly

@AshutoshAM2002
Copy link
Contributor Author

please update root readme module source-path correctly

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants