-
-
Notifications
You must be signed in to change notification settings - Fork 29
Add events for Flower #81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Any chance that tests could be added for this? |
|
Is there a good way to test if a signal has been sent with pytest? I tried: but I can't seem to get it to work. If you can help me figure out how to get it to listen for events in a pytest, I can implement it. I tested it in Flower, and it seems to work, but I'm not sure how to get the internals to work for a unit test. |
|
Some of the tests use the |
|
See also #70. |
Fixed signals and added unit tests.
|
@gersh Shout when you think this is ready for review again! You should be able to run the lints locally manually by running the same commands as CI: celery-batches/.github/workflows/main.yml Lines 23 to 39 in 59cc04f
|
|
@clokep I think I fixed the lint issues. |
|
@clokep I fixed all the lint issues. |
|
Is this still in progress? Anything that needs to be done? |
| @@ -0,0 +1,85 @@ | |||
| import asyncio | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why all the use of asyncio in these tests instead of being more similar to the existing tests?
| signals.task_revoked.disconnect(dummy_receiver) | ||
|
|
||
|
|
||
| def test_task_prerun_signal( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These don't seem to actually hook up signals and make sure they run.
Add "task-*" events so we can monitor the queue with Flower.