Skip to content

Commit cfa15f3

Browse files
committed
[bfops/debug-link-error]: fix
1 parent f4ffc15 commit cfa15f3

1 file changed

Lines changed: 10 additions & 3 deletions

File tree

.github/workflows/ci.yml

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -686,11 +686,18 @@ jobs:
686686
save-if: false
687687
prefix-key: v1
688688

689-
- name: Look for v8 outputs
689+
# This step shouldn't be needed, but somehow we end up with caches that are missing librusty_v8.a.
690+
# ChatGPT suspects that this could be due to different build invocations using the same target dir,
691+
# and this makes sense to me because we only see it in this job where we mix `cargo build -p` with
692+
# `cargo build --manifest-path` (which apparently build different dependency trees).
693+
# However, we've been unable to fix it so... /shrug
694+
- name: Check v8 outputs
690695
run: |
691-
set -x
692-
readlink -f "${CARGO_TARGET_DIR}"/ || true
693696
find "${CARGO_TARGET_DIR}"/ -type f | grep '[/_]v8' || true
697+
if ! [ -f "${CARGO_TARGET_DIR}"/debug/gn_out/obj/librusty_v8.a ]; then
698+
echo "Could not find v8 output file librusty_v8.a; rebuilding manually."
699+
cargo build v8
700+
fi
694701
695702
- name: Check quickstart-chat bindings are up to date
696703
working-directory: sdks/csharp

0 commit comments

Comments
 (0)