Skip to content

Commit 8175384

Browse files
authored
add action/reason required value checks (#80)
* add new older/outlier combo reason * fixed bug #77
1 parent 0d50019 commit 8175384

File tree

2 files changed

+12
-0
lines changed

2 files changed

+12
-0
lines changed

README.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,8 @@ The chrome extension is used by the ClinGen curation workflow (link) ...
99

1010
### v1.13 changes
1111
* Added new combo flagging candidate reason 'Older and Outlier claim with insufficient supporting evidence'.
12+
* Added requirement check that an action is selected.
13+
* Added requirement check that a reason is selected for all Flagging Candidates.
1214

1315
### v1.12.2 bug fix
1416
* Patched a bug causing the inability to read the SCV data in the Submitter column. This was introduced by a change in the underlying ClinVar UI during the 2/21/2024 release.

scvc/popup.js

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -64,6 +64,16 @@ window.addEventListener('DOMContentLoaded', () => {
6464
return;
6565
}
6666

67+
if (!data.action) {
68+
alert("An action is required. Please select one from the dropdown before submitting.");
69+
return;
70+
}
71+
72+
if (data.action = "Flagging Candidate" && !data.reason) {
73+
alert("A reason is required for Flagging Candidates. Please select one from the dropdown before submitting.");
74+
return;
75+
}
76+
6777
chrome.runtime.sendMessage(data, function(response) {
6878
var lastError = chrome.runtime.lastError;
6979
if (lastError) {

0 commit comments

Comments
 (0)