Create global-institute-of-technology-and-business-indonesia.csl #7876
Conversation
|
Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes. If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements. To update this pull request, visit the "Files changed" tab above, click on the ellipsis button in the top-right corner of your style, and then select "Edit file" to start editing:
If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable. |
|
😟 There are some issues with your submission. 1 test failedglobal-institute-of-technology-and-business-indonesia.csl Please check the test report for details. |
|
😃 Your submission passed all our automated tests. Below are some sample citations generated based on your proposed changes: global-institute-of-technology-and-business.csl (new)(Hancké dkk. 2007; CSL search by example… 2012) |
| <updated>2025-11-03T00:00:00+07:00</updated> | ||
| <rights license="http://creativecommons.org/licenses/by-sa/3.0/">This work is licensed under a Creative Commons Attribution-ShareAlike 3.0 License</rights> | ||
| </info> | ||
| <locale xml:lang="id"> |
There was a problem hiding this comment.
I see your locale overrides are quite numerous. Can you delete the ones that our standard id-ID locale already has, please?
See https://github.com/citation-style-language/locales/blob/master/locales-id-ID.xml
| <?xml version="1.0" encoding="utf-8"?> | ||
| <style xmlns="http://purl.org/net/xbiblio/csl" class="in-text" version="1.0" demote-non-dropping-particle="sort-only" default-locale="id-ID"> | ||
| <info> | ||
| <title>Global Institute of Technology and Business (Indonesian)</title> |
There was a problem hiding this comment.
Please the content of the brackets to "Bahasa Indonesia" like we have for our other styles of that locale:
https://www.zotero.org/styles?q=indonesia
| <macro name="pages"> | ||
| <group delimiter="; "> | ||
| <group> | ||
| <label variable="page" form="short" suffix=" " plural="never"/> |
There was a problem hiding this comment.
The suffix here should be better set on the group level as a delimiter. Please change and check the rest of your style for such instances.
| </group> | ||
| </macro> | ||
| <macro name="year"> | ||
| <group delimiter=" "> |
There was a problem hiding this comment.
This group only has one element, therefore does nothing. Please remove.
| </group> | ||
| </if> | ||
| <else> | ||
| <text variable="volume" prefix="Volume "/> |
There was a problem hiding this comment.
Setting the prefix here does not make sense to me.
The way this macro works is that it allows for numeric entries (e.g. "3") and will then automatically make it look like "Volume 3". If it isn't numeric, because somebody entered a string of text, then just that string will be output.
| <macro name="volume"> | ||
| <choose> | ||
| <if is-numeric="volume"> | ||
| <group> |
There was a problem hiding this comment.
This group should not have a delimiter?
| <choose> | ||
| <if is-numeric="volume"> | ||
| <group> | ||
| <text term="volume"/> |
There was a problem hiding this comment.
Please use a label instead of the term.
| <if type="report"> | ||
| <group prefix=" " suffix="." delimiter=" "> | ||
| <text variable="collection-title"/> | ||
| <text variable="number" prefix=" Report No.: "/> |
There was a problem hiding this comment.
Please use a label/term instead of hardcoding.
| <text macro="author-short"/> | ||
| <text macro="year"/> | ||
| </group> | ||
| <text variable="locator" prefix=":"/> |
There was a problem hiding this comment.
I'd replace this with a macro.
Add this macro and then call it here:
<macro name="cite-locator"> <group delimiter=" "> <choose> <if match="none" locator="page"> <label variable="locator" form="short"/> </if> </choose> <text variable="locator"/> </group> </macro>
| <text macro="editor" suffix="."/> | ||
| </group> | ||
| <text prefix=" " macro="publisher"/> | ||
| <text variable="page" prefix="hlm "/> |
There was a problem hiding this comment.
what does "hlm" stand for? This should be probably be a term/label.
| <text prefix=" " macro="publisher"/> | ||
| <text variable="page" prefix="hlm "/> | ||
| <text variable="original-title" font-style="italic" prefix=" Terjemahan dari: " suffix="."/> | ||
| <text variable="note" prefix=" Ed ke-" suffix="."/> |
There was a problem hiding this comment.
Can you explain why you are calling the "note" variable? This is the extra field in Zotero and should not be called as people have sometimes large amounts of texts here.
I would suggest to replace this with a specific variable that gets added to the extra field, but I would need to understand what you want to do here to suggest an alternative.
| <text macro="year-date"/> | ||
| <text macro="title"/> | ||
| </group> | ||
| <group suffix="."> |
There was a problem hiding this comment.
Generally, all of these conditionals for the various item types use a lot of prefix/suffixes. I'd replace a good few of them with groups to make the style more robust.
POBrien333
added
the
waiting-for-response-from-contributor
2 participants
Pull Request: Global Institute of Technology and Business Citation Style
Description
This pull request adds a new citation style for Global Institute of Technology and Business (GITB) Indonesia, an Indonesian higher education institution.
Style details:
Testing: This style has been tested with Zotero with various reference types including books, journal articles, conference papers, theses, and web sources. All outputs are correct and follow the institution's guidelines.
Checklist
Check that you've added a link to the style you used as a template in the
<info>block at the beginning of the file withrel="template".✅ Added:
<link href="http://www.zotero.org/styles/apa" rel="template"/>Check that you've added a link to the style guidelines with
rel="documentation".✅ Added:
<link href="https://gitb.ac.id" rel="documentation"/>Check that you've added yourself as the
<author>of the style or<contributor>for a style update.✅ Added author information:
Check that you've used the correct terms or labels instead of hardcoding into affixes (e.g.,
<text variable="page" prefix="pp. "/>).✅ Using proper terms like
<label variable="page" form="short"/>throughout the styleCheck that you've not used
<text value="...if not absolutely necessary.✅ No unnecessary
<text value="..."usage; all using proper variables and termsCheck that you've not changed line 1 of the style.
✅ Line 1 remains:
<?xml version="1.0" encoding="utf-8"?>Additional Information
Institution: Global Institute of Technology and Business
Country: Indonesia
Style author: Rizqiansyah Ramadhan ([email protected])
This style is specifically designed for GITB's academic writing requirements and has been validated for use in the institution's thesis and research paper submissions.
Thank you for reviewing this contribution!