-
-
Notifications
You must be signed in to change notification settings - Fork 27
Open
Labels
Description
Hi,
in the pool provider, virsh pool-build is always called after virsh pool-define. But in some cases, you don't want to build the pool. For example, when you define a LVM group pool, the LVM group in most situation already exists on the system, so, pool-build raise an error.
The error is caught and simply noticed by the provider, so it works btw, but it can be very dangerous to call it : who know the behavior of libvirt in the future, and so the risk of losing data.
May be it can be a good idea to add a "build" (or nobuild) boolean parameter to the pool type ? or at least to add the "--no-overwrite" flag to pool-build to be sure libvirt will never try something .... dangerous :)
What do you think about ?
Anthony.