ksmbd-tools: eliminate a use-after-free

Robert Morris · namjaejeon · commit 12c0ad02dbb7 · 2024-03-28T08:19:43.000+09:00
Eliminate a use-after-free.

Signed-off-by: Robert Morris &lt;rtm@ubuntu.lcs.mit.edu&gt;
Signed-off-by: Namjae Jeon &lt;linkinjeon@kernel.org&gt;
diff --git a/tools/tools.c b/tools/tools.c
@@ -218,8 +218,6 @@ gchar *ksmbd_gconvert(const gchar *str,
 			goto retry;
 		}
 
-		pr_err("Can't convert string: %s\n", err->message);
-		g_error_free(err);
 		return NULL;
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -218,8 +218,6 @@ gchar ksmbd_gconvert(const gchar str,`
`218`	`218`	`goto retry;`
`219`	`219`	`}`
`220`	`220`
`221`		`- pr_err("Can't convert string: %s\n", err->message);`
`222`		`- g_error_free(err);`
`223`	`221`	`return NULL;`
`224`	`222`	`}`
`225`	`223`