implemented files to filter functionality #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chetan
reviewed
Oct 5, 2021
| files = result.files | ||
| else | ||
| files = result.files.select do |file| | ||
| SimpleCov::Formatter::Console.files_to_filter.include?(file.filename) |
Owner
There was a problem hiding this comment.
It looks like files_to_filter would be expected to include absolute paths to each file, is that what you meant for here? I think we can modify this to at least use a path relative to the current project, what do you think?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
This commit allows you to explicitly specify the files that you want to view in the output.
The use case for this is when you have a very large code base but you want to only see the coverage information for specific files. In that case you can now modify the
files_to_filterproperty for the Formatter::Console.