Feature | Logo native colors & Color selection

[Sisyphus1813]

I'd like to add in native coloring for logos, as well as the ability to switch colors for any given logo. I intend to begin research on implementing this whilst maintaining performance, possibly using a toml config file.

[charleschetty]

Thank you for your issue.

I wrote this project for fun, and I didn't provide user configuration simply because I never considered that anyone else would use it. However, it seems that is not the case now.

I've thought about it, and I believe there's nothing wrong with providing user configurations, such as TOML or other formats.

That said, I remain cautious about adding external dependencies, as not everyone has sudo permissions on their devices. Therefore, I may implement some functions using libnvml or other libraries, but I believe it is essential to provide a simple, basic version to achieve the desired functionalities. I'm actually fine with using pure Rust libraries, as they don't require users to install anything manually.

As for performance, I believe the current performance has no impact on user experience. I explored the performance bottleneck just for fun.

So, I think even if your implementation sacrifices some performance, it’s not necessarily a bad thing.

Thank you for your interest and contribution to this project!

[Sisyphus1813]

Just an update, according to my research adding in this functionality should add in minimal to no performance overhead. Loading & parsing info from small .toml files is usually measured in the hundreds of nano seconds or less.

[charleschetty]

That’s great—I’m looking forward to seeing the new feature!