Expand the list of modules we validate. (#155)

mattmoor · web-flow · commit 567eea185cf7 · 2024-02-20T18:01:08.000-08:00
Signed-off-by: Matt Moore &lt;mattmoor@chainguard.dev&gt;
diff --git a/.github/workflows/validate.yaml b/.github/workflows/validate.yaml
@@ -11,6 +11,7 @@ jobs:
       fail-fast: false
       matrix:
         module:
+          - audit-serviceaccount
           - authorize-private-service
           - cloudevent-broker
           - cloudevent-trigger
@@ -22,6 +23,10 @@ jobs:
           - dashboard/service
           - dashboard/job
           - dashboard/cloudevent-receiver
+          - prober
+          - cron
+          - configmap
+          - secret
 
     steps:
       - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
diff --git a/modules/cron/main.tf b/modules/cron/main.tf
@@ -155,7 +155,7 @@ module "audit-delivery-serviceaccount" {
   # Note: Cloud Scheduler's usage doesn't show up in the
   # audit logs.
 
-  # TODO(mattmoor): plumb through notification channels.
+  notification_channels = var.notification_channels
 }
 
 resource "google_cloud_run_v2_job_iam_binding" "authorize-calls" {
diff --git a/modules/prober/main.tf b/modules/prober/main.tf
@@ -57,6 +57,8 @@ module "this" {
       }
     }
   }
+
+  notification_channels = var.notification_channels
 }
 
 data "google_cloud_run_v2_service" "this" {

Original file line number	Diff line number	Diff line change
`@@ -155,7 +155,7 @@ module "audit-delivery-serviceaccount" {`
`155`	`155`	`# Note: Cloud Scheduler's usage doesn't show up in the`
`156`	`156`	`# audit logs.`
`157`	`157`
`158`		`- # TODO(mattmoor): plumb through notification channels.`
	`158`	`+ notification_channels = var.notification_channels`
`159`	`159`	`}`
`160`	`160`
`161`	`161`	`resource "google_cloud_run_v2_job_iam_binding" "authorize-calls" {`
Original file line number	Diff line number	Diff line change
`@@ -57,6 +57,8 @@ module "this" {`
`57`	`57`	`}`
`58`	`58`	`}`
`59`	`59`	`}`
	`60`	`+`
	`61`	`+ notification_channels = var.notification_channels`
`60`	`62`	`}`
`61`	`63`
`62`	`64`	`data "google_cloud_run_v2_service" "this" {`