Skip to content

Commit 4731384

Browse files
authored
fix variable reference for slo (#1188)
refactoring broke the filter variable reference. Signed-off-by: Kenny Leung <[email protected]>
1 parent f9cbc3b commit 4731384

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

modules/slo/main.tf

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ resource "google_monitoring_slo" "success_cr_per_region" {
5454

5555
service = google_monitoring_custom_service.this.service_id
5656
slo_id = "${var.service_name}-success-${each.value.region}-${each.value.rolling_period_key}d"
57-
display_name = "${var.service_name} - ${each.key} Success ${each.value.rolling_period_key}d Cloud Run SLO"
57+
display_name = "${var.service_name} - ${each.value.region} Success ${each.value.rolling_period_key}d Cloud Run SLO"
5858
project = var.project_id
5959

6060
goal = var.slo.success.per_region_goal
@@ -67,7 +67,7 @@ resource "google_monitoring_slo" "success_cr_per_region" {
6767
"metric.type=\"run.googleapis.com/request_count\"",
6868
"resource.type=\"cloud_run_revision\"",
6969
"resource.label.\"service_name\"=\"${var.service_name}\"",
70-
"resource.label.\"location\"=\"${each.key}\""
70+
"resource.label.\"location\"=\"${each.value.region}\""
7171
])
7272

7373
# Bad requests

0 commit comments

Comments
 (0)