BUGFIX: WithProperty and WithIndex should copy the underying array to prevent changing sibling's values

inteon · inteon · commit 964746fb84ee · 2024-01-26T14:41:15.000+01:00
Signed-off-by: Tim Ramlot &lt;42113979+inteon@users.noreply.github.com&gt;
diff --git a/paths/path.go b/paths/path.go
@@ -108,11 +108,15 @@ func Parse(pathString string) (Path, error) {
 }
 
 func (p Path) WithProperty(part string) Path {
-	return append(p, mapPathComponent(part))
+	nePath := append(Path{}, p...)
+	nePath = append(nePath, mapPathComponent(part))
+	return nePath
 }
 
 func (p Path) WithIndex(idx int) Path {
-	return append(p, arrayPathComponent(idx))
+	nePath := append(Path{}, p...)
+	nePath = append(nePath, arrayPathComponent(idx))
+	return nePath
 }
 
 func (p Path) Property() pathComponent {

Original file line number	Diff line number	Diff line change
`@@ -108,11 +108,15 @@ func Parse(pathString string) (Path, error) {`
`108`	`108`	`}`
`109`	`109`
`110`	`110`	`func (p Path) WithProperty(part string) Path {`
`111`		`- return append(p, mapPathComponent(part))`
	`111`	`+ nePath := append(Path{}, p...)`
	`112`	`+ nePath = append(nePath, mapPathComponent(part))`
	`113`	`+ return nePath`
`112`	`114`	`}`
`113`	`115`
`114`	`116`	`func (p Path) WithIndex(idx int) Path {`
`115`		`- return append(p, arrayPathComponent(idx))`
	`117`	`+ nePath := append(Path{}, p...)`
	`118`	`+ nePath = append(nePath, arrayPathComponent(idx))`
	`119`	`+ return nePath`
`116`	`120`	`}`
`117`	`121`
`118`	`122`	`func (p Path) Property() pathComponent {`