Skip to content

Commit e8ea5e8

Browse files
Merge pull request #181 from cert-manager/self-upgrade-main
[CI] Merge self-upgrade-main into main
2 parents 7e27f38 + 578052f commit e8ea5e8

File tree

2 files changed

+19
-14
lines changed

2 files changed

+19
-14
lines changed

klone.yaml

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -10,65 +10,65 @@ targets:
1010
- folder_name: boilerplate
1111
repo_url: https://github.com/cert-manager/makefile-modules.git
1212
repo_ref: main
13-
repo_hash: 3208b2ac532c12c777df71eae416093e237f42c3
13+
repo_hash: 18dc6358de376cd941b39d6d2eb8f9c2a04fe42a
1414
repo_path: modules/boilerplate
1515
- folder_name: cert-manager
1616
repo_url: https://github.com/cert-manager/makefile-modules.git
1717
repo_ref: main
18-
repo_hash: 3208b2ac532c12c777df71eae416093e237f42c3
18+
repo_hash: 18dc6358de376cd941b39d6d2eb8f9c2a04fe42a
1919
repo_path: modules/cert-manager
2020
- folder_name: controller-gen
2121
repo_url: https://github.com/cert-manager/makefile-modules.git
2222
repo_ref: main
23-
repo_hash: 3208b2ac532c12c777df71eae416093e237f42c3
23+
repo_hash: 18dc6358de376cd941b39d6d2eb8f9c2a04fe42a
2424
repo_path: modules/controller-gen
2525
- folder_name: generate-verify
2626
repo_url: https://github.com/cert-manager/makefile-modules.git
2727
repo_ref: main
28-
repo_hash: 3208b2ac532c12c777df71eae416093e237f42c3
28+
repo_hash: 18dc6358de376cd941b39d6d2eb8f9c2a04fe42a
2929
repo_path: modules/generate-verify
3030
- folder_name: go
3131
repo_url: https://github.com/cert-manager/makefile-modules.git
3232
repo_ref: main
33-
repo_hash: 3208b2ac532c12c777df71eae416093e237f42c3
33+
repo_hash: 18dc6358de376cd941b39d6d2eb8f9c2a04fe42a
3434
repo_path: modules/go
3535
- folder_name: helm
3636
repo_url: https://github.com/cert-manager/makefile-modules.git
3737
repo_ref: main
38-
repo_hash: 3208b2ac532c12c777df71eae416093e237f42c3
38+
repo_hash: 18dc6358de376cd941b39d6d2eb8f9c2a04fe42a
3939
repo_path: modules/helm
4040
- folder_name: help
4141
repo_url: https://github.com/cert-manager/makefile-modules.git
4242
repo_ref: main
43-
repo_hash: 3208b2ac532c12c777df71eae416093e237f42c3
43+
repo_hash: 18dc6358de376cd941b39d6d2eb8f9c2a04fe42a
4444
repo_path: modules/help
4545
- folder_name: kind
4646
repo_url: https://github.com/cert-manager/makefile-modules.git
4747
repo_ref: main
48-
repo_hash: 3208b2ac532c12c777df71eae416093e237f42c3
48+
repo_hash: 18dc6358de376cd941b39d6d2eb8f9c2a04fe42a
4949
repo_path: modules/kind
5050
- folder_name: klone
5151
repo_url: https://github.com/cert-manager/makefile-modules.git
5252
repo_ref: main
53-
repo_hash: 3208b2ac532c12c777df71eae416093e237f42c3
53+
repo_hash: 18dc6358de376cd941b39d6d2eb8f9c2a04fe42a
5454
repo_path: modules/klone
5555
- folder_name: oci-build
5656
repo_url: https://github.com/cert-manager/makefile-modules.git
5757
repo_ref: main
58-
repo_hash: 3208b2ac532c12c777df71eae416093e237f42c3
58+
repo_hash: 18dc6358de376cd941b39d6d2eb8f9c2a04fe42a
5959
repo_path: modules/oci-build
6060
- folder_name: oci-publish
6161
repo_url: https://github.com/cert-manager/makefile-modules.git
6262
repo_ref: main
63-
repo_hash: 3208b2ac532c12c777df71eae416093e237f42c3
63+
repo_hash: 18dc6358de376cd941b39d6d2eb8f9c2a04fe42a
6464
repo_path: modules/oci-publish
6565
- folder_name: repository-base
6666
repo_url: https://github.com/cert-manager/makefile-modules.git
6767
repo_ref: main
68-
repo_hash: 3208b2ac532c12c777df71eae416093e237f42c3
68+
repo_hash: 18dc6358de376cd941b39d6d2eb8f9c2a04fe42a
6969
repo_path: modules/repository-base
7070
- folder_name: tools
7171
repo_url: https://github.com/cert-manager/makefile-modules.git
7272
repo_ref: main
73-
repo_hash: 3208b2ac532c12c777df71eae416093e237f42c3
73+
repo_hash: 18dc6358de376cd941b39d6d2eb8f9c2a04fe42a
7474
repo_path: modules/tools

make/_shared/helm/helm.mk

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,11 @@ ifndef helm_chart_version
3232
$(error helm_chart_version is not set)
3333
endif
3434

35+
ifndef helm_chart_app_version
36+
# Default to the same as the chart version
37+
helm_chart_app_version = $(helm_chart_version)
38+
endif
39+
3540
ifndef helm_values_mutation_function
3641
$(error helm_values_mutation_function is not set)
3742
endif
@@ -59,7 +64,7 @@ $(helm_chart_archive): $(helm_chart_sources) | $(NEEDS_HELM) $(NEEDS_YQ) $(bin_d
5964

6065
mkdir -p $(dir $@)
6166
$(HELM) package $(helm_chart_source_dir_versioned) \
62-
--app-version $(helm_chart_version) \
67+
--app-version $(helm_chart_app_version) \
6368
--version $(helm_chart_version) \
6469
--destination $(dir $@)
6570

0 commit comments

Comments
 (0)