Update fuzzer functions to use new randfill.Continue

Fixes the following panic:

  === FAIL: pkg/convert/internal/apis/certmanager/install TestRoundTripTypes (0.00s)
  panic: Filler.Funcs: customFuncs' second argument must be a randfill.Continue [recovered]
          panic: Filler.Funcs: customFuncs' second argument must be a randfill.Continue

  goroutine 20 [running]:
  testing.tRunner.func1.2({0xde37c0, 0x10c11e0})
          /home/richard/projects/cert-manager/cmctl/_bin/tools/goroot/src/testing/testing.go:1734 +0x21c
  testing.tRunner.func1()
          /home/richard/projects/cert-manager/cmctl/_bin/tools/goroot/src/testing/testing.go:1737 +0x35e
  panic({0xde37c0?, 0x10c11e0?})
          /home/richard/projects/cert-manager/cmctl/_bin/tools/goroot/src/runtime/panic.go:792 +0x132
  sigs.k8s.io/randfill.(*Filler).Funcs(0xc00012c4e0, {0xc000105880, 0x13, 0xc0001056c0?})
          /home/richard/projects/pkg/mod/sigs.k8s.io/[email protected]/randfill.go:145 +0x2b8
  k8s.io/apimachinery/pkg/api/apitesting/fuzzer.FuzzerFor(0xc00016fed0, {0x10c5430, 0xc00024d500}, {0xc0002d2000, {0x10c3d60, 0xc00013f158}, {0xc0001056c0, 0x3, 0x4}, {0x10c94f0, ...}})
          /home/richard/projects/pkg/mod/k8s.io/[email protected]/pkg/api/apitesting/fuzzer/fuzzer.go:40 +0xcd
  k8s.io/apimachinery/pkg/api/apitesting/roundtrip.RoundTripTestForScheme(0xc000105340, 0xc0002d2000, 0xfd33c0)
          /home/richard/projects/pkg/mod/k8s.io/[email protected]/pkg/api/apitesting/roundtrip/roundtrip.go:59 +0x1a5
  k8s.io/apimachinery/pkg/api/apitesting/roundtrip.RoundTripTestForAPIGroup(0xc000105340, 0xfd1fd0, 0xfd33c0)
          /home/richard/projects/pkg/mod/k8s.io/[email protected]/pkg/api/apitesting/roundtrip/roundtrip.go:53 +0x48
  github.com/cert-manager/cmctl/v2/pkg/convert/internal/apis/certmanager/install.TestRoundTripTypes(0xc000105340?)
          /home/richard/projects/cert-manager/cmctl/pkg/convert/internal/apis/certmanager/install/roundtrip_test.go:28 +0x25
  testing.tRunner(0xc000105340, 0xfd1e98)
          /home/richard/projects/cert-manager/cmctl/_bin/tools/goroot/src/testing/testing.go:1792 +0xf4
  created by testing.(*T).Run in goroutine 1
          /home/richard/projects/cert-manager/cmctl/_bin/tools/goroot/src/testing/testing.go:1851 +0x413

Signed-off-by: Richard Wall <[email protected]>

Author: wallrj

go.mod

@@ -24,6 +24,7 @@ require (
 	k8s.io/utils v0.0.0-20241210054802-24370beab758
 	sigs.k8s.io/controller-runtime v0.20.4
 	sigs.k8s.io/gateway-api v1.3.0
+	sigs.k8s.io/randfill v1.0.0
 	sigs.k8s.io/yaml v1.4.0
 )
 
@@ -182,6 +183,5 @@ require (
 	sigs.k8s.io/json v0.0.0-20241014173422-cfa47c3a1cc8 // indirect
 	sigs.k8s.io/kustomize/api v0.19.0 // indirect
 	sigs.k8s.io/kustomize/kyaml v0.19.0 // indirect
-	sigs.k8s.io/randfill v1.0.0 // indirect
 	sigs.k8s.io/structured-merge-diff/v4 v4.7.0 // indirect
 )

pkg/convert/internal/apis/acme/fuzzer/fuzzer.go

@@ -18,31 +18,31 @@ package fuzzer
 
 import (
 	v1 "github.com/cert-manager/cert-manager/pkg/apis/certmanager/v1"
-	fuzz "github.com/google/gofuzz"
 	apiextensionsv1 "k8s.io/apiextensions-apiserver/pkg/apis/apiextensions/v1"
 	runtimeserializer "k8s.io/apimachinery/pkg/runtime/serializer"
+	"sigs.k8s.io/randfill"
 
 	"github.com/cert-manager/cmctl/v2/pkg/convert/internal/apis/acme"
 )
 
 // Funcs returns the fuzzer functions for the apps api group.
 var Funcs = func(codecs runtimeserializer.CodecFactory) []interface{} {
 	return []interface{}{
-		func(s *acme.Order, c fuzz.Continue) {
-			c.FuzzNoCustom(s) // fuzz self without calling this function again
+		func(s *acme.Order, c randfill.Continue) {
+			c.FillNoCustom(s) // fuzz self without calling this function again
 
 			if s.Spec.IssuerRef.Kind == "" {
 				s.Spec.IssuerRef.Kind = v1.IssuerKind
 			}
 		},
-		func(s *acme.Challenge, c fuzz.Continue) {
-			c.FuzzNoCustom(s) // fuzz self without calling this function again
+		func(s *acme.Challenge, c randfill.Continue) {
+			c.FillNoCustom(s) // fuzz self without calling this function again
 
 			if s.Spec.IssuerRef.Kind == "" {
 				s.Spec.IssuerRef.Kind = v1.IssuerKind
 			}
 		},
-		func(s *apiextensionsv1.JSON, c fuzz.Continue) {
+		func(s *apiextensionsv1.JSON, c randfill.Continue) {
 			// ensure the webhook's config is valid JSON
 			s.Raw = []byte("{}")
 		},

pkg/convert/internal/apis/certmanager/fuzzer/fuzzer.go

@@ -18,9 +18,9 @@ package fuzzer
 
 import (
 	v1 "github.com/cert-manager/cert-manager/pkg/apis/certmanager/v1"
-	fuzz "github.com/google/gofuzz"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 	runtimeserializer "k8s.io/apimachinery/pkg/runtime/serializer"
+	"sigs.k8s.io/randfill"
 
 	acmefuzzer "github.com/cert-manager/cmctl/v2/pkg/convert/internal/apis/acme/fuzzer"
 	"github.com/cert-manager/cmctl/v2/pkg/convert/internal/apis/certmanager"
@@ -29,8 +29,8 @@ import (
 // Funcs returns the fuzzer functions for the apps api group.
 var Funcs = func(codecs runtimeserializer.CodecFactory) []interface{} {
 	return append(acmefuzzer.Funcs(codecs), []interface{}{
-		func(s *certmanager.Certificate, c fuzz.Continue) {
-			c.FuzzNoCustom(s) // fuzz self without calling this function again
+		func(s *certmanager.Certificate, c randfill.Continue) {
+			c.FillNoCustom(s) // fuzz self without calling this function again
 
 			if len(s.Spec.DNSNames) == 0 {
 				s.Spec.DNSNames = []string{s.Spec.CommonName}
@@ -42,8 +42,8 @@ var Funcs = func(codecs runtimeserializer.CodecFactory) []interface{} {
 				s.Spec.Duration = &metav1.Duration{Duration: v1.DefaultCertificateDuration}
 			}
 		},
-		func(s *certmanager.CertificateRequest, c fuzz.Continue) {
-			c.FuzzNoCustom(s) // fuzz self without calling this function again
+		func(s *certmanager.CertificateRequest, c randfill.Continue) {
+			c.FillNoCustom(s) // fuzz self without calling this function again
 
 			if s.Spec.IssuerRef.Kind == "" {
 				s.Spec.IssuerRef.Kind = v1.IssuerKind