Merge pull request #404 from ARichman555/refresh-cache

Refresh the cached client when the issuer is updated

Author: cert-manager-prow[bot]

pkg/aws/pca.go

@@ -141,6 +141,14 @@ func ClearProvisioners() {
 	collection.Clear()
 }
 
+// DeleteProvisioner will remove a provisioner if it already exists
+func DeleteProvisioner(ctx context.Context, client client.Client, name types.NamespacedName) {
+	_, exists := collection.Load(name)
+	if exists {
+		collection.Delete(name)
+	}
+}
+
 // GetProvisioner gets a provisioner that has previously been stored or creates a new one
 func GetProvisioner(ctx context.Context, client client.Client, name types.NamespacedName, spec *api.AWSPCAIssuerSpec) (GenericProvisioner, error) {
 	value, _ := collection.Load(name)

pkg/aws/pca_test.go

@@ -246,6 +246,11 @@ func TestProvisonerOperation(t *testing.T) {
 	output, err := GetProvisioner(context.TODO(), fakeClient, types.NamespacedName{Namespace: "ns1", Name: "issuer1"}, issSpec)
 	assert.Equal(t, output, provisioner)
 	assert.Equal(t, err, nil)
+
+	DeleteProvisioner(context.TODO(), fakeClient, types.NamespacedName{Namespace: "ns1", Name: "issuer1"})
+	output, err = GetProvisioner(context.TODO(), fakeClient, types.NamespacedName{Namespace: "ns1", Name: "issuer1"}, issSpec)
+	assert.NotEqual(t, output, provisioner)
+	assert.Equal(t, err, nil)
 }
 
 func TestPCATemplateArn(t *testing.T) {

pkg/controllers/genericissuer_controller.go

@@ -72,6 +72,7 @@ func (r *GenericIssuerReconciler) Reconcile(ctx context.Context, req ctrl.Reques
 		return ctrl.Result{}, err
 	}
 
+	awspca.DeleteProvisioner(ctx, r.Client, req.NamespacedName)
 	cfg, err := awspca.GetConfig(ctx, r.Client, spec)
 	if err != nil {
 		log.Error(err, "Error loading config")