feat(demo): track mouse by default #518
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
yes, it make sense. |
Contributor
Author
|
In that case PR #520 superseeds this PR. Edit: At least we can test mouseTrack performance issues within the demo apps. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-targument of the demo app to disable mouse tracking rather than enable it, and enable it by default.Plenty of the widgets respond to mouse hover events and this is an impressive feature to showcase in the demo app as well as helping us to ensure that mouse tracking behaviours are routinely tested when developing new widgets and library features such as
ToolTips for instance.I tested it in the pyodide sandbox and mouse tracking works just fine in the browser too. There is an argument to be made that perhaps
mouseTrackcould beTrueby default inTTkcore?