refactor: remove unused Google OAuth parameter and related references (#977)

Author: gcharest

terraform/ecs.tf

@@ -18,7 +18,6 @@ data "template_file" "sre-bot" {
     fargate_cpu                      = var.fargate_cpu
     fargate_memory                   = var.fargate_memory
     aws_region                       = "ca-central-1"
-    PICKLE_STRING                    = aws_ssm_parameter.google_oauth_pickle_string.arn
     GCP_SRE_SERVICE_ACCOUNT_KEY_FILE = aws_ssm_parameter.gcp_sre_service_account_key.arn
   }
 }

terraform/iam.tf

@@ -29,7 +29,6 @@ data "aws_iam_policy_document" "sre-bot_secrets_manager" {
     ]
     resources = [
       "arn:aws:ssm:ca-central-1:${data.aws_caller_identity.current.account_id}:parameter/sre-bot-config",
-      aws_ssm_parameter.google_oauth_pickle_string.arn,
       aws_ssm_parameter.gcp_sre_service_account_key.arn
     ]
   }

terraform/ssm.tf

@@ -1,14 +1,3 @@
-resource "aws_ssm_parameter" "google_oauth_pickle_string" {
-  name  = "google_oauth_pickle_string"
-  type  = "SecureString"
-  value = var.google_oauth_pickle_string
-
-  tags = {
-    CostCentre = var.billing_code
-    Terraform  = true
-  }
-}
-
 resource "aws_ssm_parameter" "gcp_sre_service_account_key" {
   name  = "gcp_sre_service_account_key"
   type  = "SecureString"

terraform/templates/sre-bot.json.tpl

@@ -26,10 +26,6 @@
       }
     ],
     "secrets": [
-      {
-        "name": "PICKLE_STRING",
-        "valueFrom": "${PICKLE_STRING}"
-      },
       {
         "name": "GCP_SRE_SERVICE_ACCOUNT_KEY_FILE",
         "valueFrom": "${GCP_SRE_SERVICE_ACCOUNT_KEY_FILE}"

terraform/variables.tf

@@ -13,12 +13,6 @@ variable "fargate_memory" {
   default = 1024
 }
 
-variable "google_oauth_pickle_string" {
-  description = "(Required) The Google OAuth pickle string"
-  type        = string
-  sensitive   = true
-}
-
 variable "gcp_sre_service_account_key" {
   description = "(Required) The GCP SRE service account key"
   type        = string
@@ -51,9 +45,6 @@ variable "authorized_endpoints_with_constraints" {
   }))
   default = [
     { path = "/", positional_constraint = "EXACTLY" },
-    { path = "/auth/login", positional_constraint = "EXACTLY" },
-    { path = "/auth/logout", positional_constraint = "EXACTLY" },
-    { path = "/auth/callback", positional_constraint = "EXACTLY" },
     { path = "/auth/me", positional_constraint = "EXACTLY" },
     { path = "/request_access", positional_constraint = "EXACTLY" },
     { path = "/active_requests", positional_constraint = "EXACTLY" },
@@ -62,7 +53,6 @@ variable "authorized_endpoints_with_constraints" {
     { path = "/geolocate", positional_constraint = "STARTS_WITH" },
     { path = "/hook", positional_constraint = "STARTS_WITH" },
     { path = "/version", positional_constraint = "EXACTLY" },
-    { path = "/static", positional_constraint = "STARTS_WITH" },
     { path = "/access", positional_constraint = "STARTS_WITH" },
     { path = "/health", positional_constraint = "EXACTLY" }
   ]