Tweaked sns-sms-success-rate-canadian-numbers-us-west-2-critical #1854
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added the threshold and additional metrics similar to the warning version of this alarm [review]
|
Updating alarms ⏰? Great! Please update the Google Sheet and add a 👍 to this message after 🙏 |
whabanks
commented
Apr 23, 2025
| label = "Guarded Alarm Condition" | ||
| return_data = true | ||
| expression = "IF(successRate < 0.85 AND messagesPublished > 75, 0, 1)" | ||
| expression = "IF(successRate < 0.85 AND messagesPublished > 85, 0, 1)" |
Contributor
Author
There was a problem hiding this comment.
This was a typo on my part
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Updating alarms ⏰? Great! Please update the Google Sheet and add a 👍 to this message after 🙏 |
1 similar comment
|
Updating alarms ⏰? Great! Please update the Google Sheet and add a 👍 to this message after 🙏 |
andrewleith
approved these changes
Apr 23, 2025
Member
andrewleith
left a comment
andrewleith
left a comment
There was a problem hiding this comment.
LGTM, although I do find it quite hard to read/validate metrics/alarms/etc. in general
| } | ||
|
|
||
| metric_query { | ||
| id = "alarmCondition" |
Member
There was a problem hiding this comment.
Does it not matter that there are two metric_query's with the same id?
Contributor
Author
There was a problem hiding this comment.
I think the metric_query's are scoped to the metric alarms themselves and shouldn't collide. @P0NDER0SA is that correct?
|
Updating alarms ⏰? Great! Please update the Google Sheet and add a 👍 to this message after 🙏 |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the SNS SMS success rate alarm for Canadian numbers in the US West 2 region by tweaking threshold values and switching to metric queries for improved alarm evaluation.
- Updated the volume threshold in the alarm condition for SNS SMS success rate.
- Refactored the critical alarm resource to use metric queries instead of direct metric configuration.
Comments suppressed due to low confidence (2)
aws/common/cloudwatch_alarms_sms.tf:143
- Verify that the updated threshold for messagesPublished (now 85) meets the intended alerting criteria compared to the previous value.
expression = "IF(successRate < 0.85 AND messagesPublished > 85, 0, 1)"
aws/common/cloudwatch_alarms_sms.tf:177
- Confirm that setting the threshold as a string '1' is supported and behaves correctly in numeric comparisons within this CloudWatch alarm configuration.
threshold = "1"
staging: common✅ Terraform Init: Plan: 0 to add, 2 to change, 0 to destroyShow summary
Show planResource actions are indicated with the following symbols:
~ update in-place
Terraform will perform the following actions:
# aws_cloudwatch_metric_alarm.sns-sms-success-rate-canadian-numbers-us-west-2-critical[0] will be updated in-place
~ resource "aws_cloudwatch_metric_alarm" "sns-sms-success-rate-canadian-numbers-us-west-2-critical" {
~ dimensions = {
- "Country" = "CA" -> null
- "SMSType" = "Transactional" -> null
}
id = "sns-sms-success-rate-canadian-numbers-us-west-2-critical"
- metric_name = "SMSSuccessRate" -> null
- namespace = "AWS/SNS" -> null
- period = 43200 -> null
- statistic = "Average" -> null
tags = {}
~ threshold = 0.75 -> 1
# (16 unchanged attributes hidden)
+ metric_query {
+ id = "messagesPublished"
+ label = "Messages Published"
+ return_data = false
# (2 unchanged attributes hidden)
+ metric {
+ dimensions = {
+ "Country" = "CA"
+ "SMSType" = "Transactional"
}
+ metric_name = "NumberOfMessagesPublished"
+ namespace = "AWS/SNS"
+ period = 43200
+ stat = "Sum"
# (1 unchanged attribute hidden)
}
}
+ metric_query {
+ id = "successRate"
+ label = "Success Rate"
+ return_data = false
# (2 unchanged attributes hidden)
+ metric {
+ dimensions = {
+ "Country" = "CA"
+ "SMSType" = "Transactional"
}
+ metric_name = "SMSSuccessRate"
+ namespace = "AWS/SNS"
+ period = 43200
+ stat = "Average"
# (1 unchanged attribute hidden)
}
}
+ metric_query {
+ expression = "IF(successRate < 0.75 AND messagesPublished > 75, 0, 1)"
+ id = "alarmCondition"
+ label = "Guarded Alarm Condition"
+ return_data = true
# (1 unchanged attribute hidden)
}
}
# aws_cloudwatch_metric_alarm.sns-sms-success-rate-canadian-numbers-us-west-2-warning[0] will be updated in-place
~ resource "aws_cloudwatch_metric_alarm" "sns-sms-success-rate-canadian-numbers-us-west-2-warning" {
id = "sns-sms-success-rate-canadian-numbers-us-west-2-warning"
tags = {}
# (22 unchanged attributes hidden)
- metric_query {
- id = "messagesPublished" -> null
- label = "Messages Published" -> null
- period = 0 -> null
- return_data = false -> null
# (2 unchanged attributes hidden)
- metric {
- dimensions = {
- "Country" = "CA"
- "SMSType" = "Transactional"
} -> null
- metric_name = "NumberOfMessagesPublished" -> null
- namespace = "AWS/SNS" -> null
- period = 43200 -> null
- stat = "Sum" -> null
# (1 unchanged attribute hidden)
}
}
- metric_query {
- id = "successRate" -> null
- label = "Success Rate" -> null
- period = 0 -> null
- return_data = false -> null
# (2 unchanged attributes hidden)
- metric {
- dimensions = {
- "Country" = "CA"
- "SMSType" = "Transactional"
} -> null
- metric_name = "SMSSuccessRate" -> null
- namespace = "AWS/SNS" -> null
- period = 43200 -> null
- stat = "Average" -> null
# (1 unchanged attribute hidden)
}
}
- metric_query {
- expression = "IF(successRate < 0.85 AND messagesPublished > 75, 0, 1)" -> null
- id = "alarmCondition" -> null
- label = "Guarded Alarm Condition" -> null
- period = 0 -> null
- return_data = true -> null
# (1 unchanged attribute hidden)
}
+ metric_query {
+ expression = "IF(successRate < 0.85 AND messagesPublished > 85, 0, 1)"
+ id = "alarmCondition"
+ label = "Guarded Alarm Condition"
+ return_data = true
# (1 unchanged attribute hidden)
}
+ metric_query {
+ id = "messagesPublished"
+ label = "Messages Published"
+ return_data = false
+ metric {
+ dimensions = {
+ "Country" = "CA"
+ "SMSType" = "Transactional"
}
+ metric_name = "NumberOfMessagesPublished"
+ namespace = "AWS/SNS"
+ period = 43200
+ stat = "Sum"
}
}
+ metric_query {
+ id = "successRate"
+ label = "Success Rate"
+ return_data = false
+ metric {
+ dimensions = {
+ "Country" = "CA"
+ "SMSType" = "Transactional"
}
+ metric_name = "SMSSuccessRate"
+ namespace = "AWS/SNS"
+ period = 43200
+ stat = "Average"
}
}
}
Plan: 0 to add, 2 to change, 0 to destroy.
Warning: Argument is deprecated
with aws_s3_bucket.csv_bucket,
on s3.tf line 5, in resource "aws_s3_bucket" "csv_bucket":
5: resource "aws_s3_bucket" "csv_bucket" {
server_side_encryption_configuration is deprecated. Use the
aws_s3_bucket_server_side_encryption_configuration resource instead.
(and 69 more similar warnings elsewhere)
─────────────────────────────────────────────────────────────────────────────
Saved the plan to: plan.tfplan
To perform exactly these actions, run the following command to apply:
terraform apply "plan.tfplan"
Show Conftest resultsWARN - plan.json - main - Missing Common Tags: ["aws_athena_workgroup.ad_hoc"]
WARN - plan.json - main - Missing Common Tags: ["aws_athena_workgroup.build_tables"]
WARN - plan.json - main - Missing Common Tags: ["aws_athena_workgroup.primary"]
WARN - plan.json - main - Missing Common Tags: ["aws_athena_workgroup.support"]
WARN - plan.json - main - Missing Common Tags: ["aws_budgets_budget.cloudwatch_data_scanned"]
WARN - plan.json - main - Missing Common Tags: ["aws_budgets_budget.notify_global"]
WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_event_rule.aws_health[0]"]
WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_log_group.route53_resolver_query_log[0]"]
WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_log_group.sns_deliveries[0]"]
WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_log_group.sns_deliveries_failures[0]"]
WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_log_group.sns_deliveries_failures_us_west_2[0]"]
WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_log_group.sns_deliveries_us_west_2[0]"]
WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_metric_alarm.bulk-bulk-not-being-processed-critical[0]"]
WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_metric_alarm.bulk-bulk-not-being-processed-warning[0]"]
WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_metric_alarm.bulk-inflights-not-being-processed-critical[0]"]
WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_metric_alarm.bulk-inflights-not-being-processed-warning[0]"]
WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_metric_alarm.bulk-not-being-processed-critical[0]"]
WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_metric_alarm.bulk-not-being-processed-warning[0]"]
WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_metric_alarm.contact-3-500-error-15-minutes-critical[0]"]
WARN - plan.json - main - Missing Common... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary | Résumé
This PR tweaks the
sns-sms-success-rate-canadian-numbers-us-west-2-criticalalarm in the same manner as the warning alarm adding a volume threshold to ensure that the alarm does not trigger due to a reduction in sending volume.Related Issues | Cartes liées
Before merging this PR
Read code suggestions left by the
cds-ai-codereviewer bot. Address
valid suggestions and shortly write down reasons to not address others. To help
with the classification of the comments, please use these reactions on each of the
comments made by the AI review:
The classifications will be extracted and summarized into an analysis of how helpful
or not the AI code review really is.
Test instructions | Instructions pour tester la modification
TODO: Fill in test instructions for the reviewer.
Release Instructions | Instructions pour le déploiement
None.
Reviewer checklist | Liste de vérification du réviseur