-
Notifications
You must be signed in to change notification settings - Fork 95
[Feature] VTK output vars #684
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #684 +/- ##
===========================================
- Coverage 96.68% 96.67% -0.01%
===========================================
Files 123 123
Lines 25391 25560 +169
===========================================
+ Hits 24549 24710 +161
- Misses 842 850 +8
Continue to review full report at Codecov.
|
kks32
requested changes
Aug 5, 2020
kks32
reviewed
Aug 6, 2020
…vtk-output-vars
kks32
requested changes
Aug 8, 2020
kks32
reviewed
Aug 9, 2020
kks32
requested changes
Aug 9, 2020
kks32
reviewed
Aug 9, 2020
kks32
requested changes
Aug 10, 2020
tianchiTJ
approved these changes
Aug 10, 2020
kks32
requested changes
Aug 10, 2020
kks32
reviewed
Aug 11, 2020
kks32
requested changes
Aug 11, 2020
kks32
approved these changes
Aug 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the PR
This PR solves issue #594 to output variables from JSON with unknown type. A new map to link the string specified in JSON and a new
VariableTypeclass is created. Also, this removes the default output variables of displacements, velocities, stresses, and strains.Every time a user wants to output a variable, just add the string and type to the list specified in
src/mpm.ccand at theinitialise()function inparticle.tccfor which variable to return using lambda function.The JSON list "vtk" is ready back to be used.
Related Issues/PRs
Issue #594
Additional context
tsl_map✔️)