Behavior of `read-file` is inconsistent with `load`

[TimDeve]

read-file behavior is inconsistent with load's as the path is relative to where the compiler is ran rather than relative to which file the function is invoked in.

[sdilts]

What is the correct behavior?

[TimDeve]

If it matched load it would be relative to the file it's used in.

[vpashkov]

Anyone is working on this?
Can I take this?

[sdilts]

Go for it.

…

On Tue, Jun 9, 2020, 13:47 Vadim ***@***.***> wrote: Anyone is working on this? Can I take this? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#811 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AC2LPZSJOPSIJUQWP57F5ETRV2GTTANCNFSM4NC36FDA> .

[TimDeve]

Wait am I confused? I thought for sure that load loaded file relative to the file it was invoked in but I don't think that's true. So I guess they are consistent?

[scolsen]

Wait am I confused? I thought for sure that load loaded file relative to the file it was invoked in but I don't think that's true. So I guess they are consistent?

I believe it loads relative to the "Project.config.source-dir" -- it may not be called source-dir but it's something like that.

[TimDeve]

In any case, I was incorrect so I'm gonna close this

[vpashkov]

IIUC, load checks several places:

1. The path itself (in case it's a full path, I guess)
2. Current file directory (similar to the read-file)
3. Project.config.search-path
4. $CARP_DIR/core directory (e.g. ~/projects/Carp/core)
5. $XDG_CACHE_HOME/libs(e.g. ~/.cache/libs)

read-file only tries to load a file relative to the file it's used in.

[TimDeve]

Ah, thanks for the load explanation, that's probably why I was confused about the behavior.

For read-file I just checked and it is relative to where the compiler is invoked not the file it's used in.

~/d/sandbox » mkdir example                                                                                                   Ô£ÿ 130
~/d/sandbox » echo "hello" > example/some.txt
~/d/sandbox » echo '(defn main [] (println* (Dynamic.read-file "./some.txt"))) ' > example/main.carp
~/d/sandbox » carp -x example/main.carp
The argument to `read-file` `./some.txt` does not exist at /home/tim/dev/sandbox/example/main.carp:1:44.
~/d/sandbox » cd example                                                                                                        Ô£ÿ 1
~/d/s/example » carp -x main.carp
hello

[TimDeve]

Maybe it would just make more sense to make (file) return the current file like __dirname in NodeJS and then you can compose that with read-file.