Commit d366454
authored
chore: retrieve google sa in batch job only if it's specified (#653)
# Description
Previously, the batch-job in Merlin was using BQ table and when client
tries to submit a batch-job, Merlin assumed that a Google Service
Account will be provided in the job configuration. But as we have added
option for using MaxCompute and it doesn't need a Google SA, I'm adding
a check where it will only try to retrieve the service account if it's
provided
# Modifications
<!-- Summarize the key code changes. -->
# Tests
# Checklist
- [x] Added PR label
- [ ] Added unit test, integration, and/or e2e tests
- [x] Tested locally
- [ ] Updated documentation
- [ ] Update Swagger spec if the PR introduce API changes
- [ ] Regenerated Golang and Python client if the PR introduces API
changes
# Release Notes
```release-note
remove google sa dependency in batch job
```1 parent 96cf05d commit d366454
1 file changed
+6
-4
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
324 | 324 | | |
325 | 325 | | |
326 | 326 | | |
327 | | - | |
328 | | - | |
329 | | - | |
| 327 | + | |
| 328 | + | |
| 329 | + | |
| 330 | + | |
| 331 | + | |
| 332 | + | |
330 | 333 | | |
331 | | - | |
332 | 334 | | |
333 | 335 | | |
334 | 336 | | |
| |||
0 commit comments