Merge pull request #1041 from josbeir/5.x

Allow SqlPanel skip drivers with no setLogger method

Author: LordSimal

src/Panel/SqlLogPanel.php

@@ -68,6 +68,11 @@ public static function addConnection(string $name): void
             return;
         }
         $driver = $connection->getDriver();
+
+        if (!method_exists($driver, 'setLogger')) {
+            return;
+        }
+
         $logger = null;
         if ($driver instanceof Driver) {
             $logger = $driver->getLogger();

tests/TestCase/Panel/SqlLogPanelTest.php

@@ -124,4 +124,21 @@ public function testSummary()
         $result = $this->panel->summary();
         $this->assertMatchesRegularExpression('/\d+ \\/ \d+(\.\d+)? ms/', $result);
     }
+
+    /**
+     * Testing a simple connection (no set/getLogger on driver).
+     *
+     * @return void
+     */
+    public function testWithSimpleConnection()
+    {
+        ConnectionManager::setConfig('simple', [
+            'className' => 'DebugKit\TestApp\Stub\SimpleConnectionStub',
+        ]);
+
+        $this->panel->addConnection('simple'); // should not throw an error
+        $this->assertTrue(true);
+
+        ConnectionManager::drop('simple');
+    }
 }

tests/test_app/Stub/SimpleConnectionStub.php

@@ -0,0 +1,37 @@
+<?php
+declare(strict_types=1);
+
+namespace DebugKit\TestApp\Stub;
+
+use Cake\Cache\Cache;
+use Cake\Datasource\ConnectionInterface;
+use Psr\SimpleCache\CacheInterface;
+use stdClass;
+
+class SimpleConnectionStub implements ConnectionInterface
+{
+    public function getDriver(string $role = self::ROLE_WRITE): object
+    {
+        return new stdClass();
+    }
+
+    public function setCacher(CacheInterface $cacher)
+    {
+        return $this;
+    }
+
+    public function getCacher(): CacheInterface
+    {
+        return Cache::pool('_simple_connection_stub_');
+    }
+
+    public function configName(): string
+    {
+        return 'simple_connection_stub';
+    }
+
+    public function config(): array
+    {
+        return [];
+    }
+}