Skip to content

Commit 583e4f7

Browse files
committed
cleaned up some classes
1 parent 7d82dfd commit 583e4f7

File tree

3 files changed

+8
-7
lines changed

3 files changed

+8
-7
lines changed

src/main/java/org/cbioportal/application/rest/vcolumnstore/ColumnMutationController.java

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -49,22 +49,21 @@ public ColumnMutationController(GetMutationUseCases getMutationUseCases) {
4949
this.getMutationUseCases = getMutationUseCases;
5050
}
5151
@Hidden
52-
@RequestMapping(
52+
@PostMapping(
5353
value = "/mutations/fetch",
54-
method = RequestMethod.POST,
5554
consumes = MediaType.APPLICATION_JSON_VALUE,
5655
produces = MediaType.APPLICATION_JSON_VALUE)
5756
public ResponseEntity<List<Mutation>> fetchMutationsInMultipleMolecularProfiles(
5857
@Parameter(hidden = true) // prevent reference to this attribute in the swagger-ui interface
5958
@RequestAttribute(required = false, value = "involvedCancerStudies")
60-
Collection<String> involvedCancerStudies,
59+
Collection<String> involvedCancerStudies, //variable is not being used- should be removed
6160
@Parameter(
6261
hidden =
6362
true) // prevent reference to this attribute in the swagger-ui interface. this
6463
// attribute is needed for now but was needed previously for @PreAuthorize .
6564
@Valid
6665
@RequestAttribute(required = false, value = "interceptedMutationMultipleStudyFilter")
67-
MutationMultipleStudyFilter interceptedMutationMultipleStudyFilter,
66+
MutationMultipleStudyFilter interceptedMutationMultipleStudyFilter, // This is being intercepted will leave this
6867
@Parameter(
6968
required = true,
7069
description =
@@ -107,7 +106,6 @@ public ResponseEntity<List<Mutation>> fetchMutationsInMultipleMolecularProfiles(
107106
getMutationUseCases.fetchAllMutationsInProfileUseCase().execute(
108107
mutationMultipleStudyFilter,
109108
mutationSearchCriteria);
110-
111109
return ResponseEntity.ok(mutations);
112110
}
113111
}

src/main/java/org/cbioportal/domain/mutation/usecase/FetchAllMutationsInProfileUseCase.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,6 @@ public List<Mutation> execute(MutationMultipleStudyFilter mutationMultipleStudyF
3232
null,
3333
mutationMultipleStudyFilter.getEntrezGeneIds(),
3434
mutationSearchCriteria);
35-
3635
}
3736

3837
List<String> molecularProfileIds=

src/main/java/org/cbioportal/shared/MutationSearchCriteria.java

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,5 +3,9 @@
33
import org.cbioportal.legacy.web.parameter.Direction;
44
import org.cbioportal.legacy.web.parameter.Projection;
55

6-
public record MutationSearchCriteria(Projection projection, Integer pageSize, Integer pageNumber, String sortBy, Direction direction ) {
6+
public record MutationSearchCriteria(Projection projection,
7+
Integer pageSize,
8+
Integer pageNumber,
9+
String sortBy,
10+
Direction direction ) {
711
}

0 commit comments

Comments
 (0)