Skip to content

Commit 2a9b607

Browse files
author
Kevin Klopfenstein
committed
feat: #18 implement vm migrating feature
1 parent 8e9301e commit 2a9b607

File tree

3 files changed

+227
-65
lines changed

3 files changed

+227
-65
lines changed

‎kubevirt/.eslintcache‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
[{"/home/klokev20/headlamp-plugins/kubevirt/src/headlamp-plugin.d.ts":"1","/home/klokev20/headlamp-plugins/kubevirt/src/index.tsx":"2","/home/klokev20/headlamp-plugins/kubevirt/src/kubevirt/Terminal/Terminal.tsx":"3","/home/klokev20/headlamp-plugins/kubevirt/src/kubevirt/VirtualMachineInstance/Details.tsx":"4","/home/klokev20/headlamp-plugins/kubevirt/src/kubevirt/VirtualMachineInstance/List.tsx":"5","/home/klokev20/headlamp-plugins/kubevirt/src/kubevirt/VirtualMachineInstance/VirtualMachineInstance.tsx":"6","/home/klokev20/headlamp-plugins/kubevirt/src/kubevirt/VirtualMachines/Details.tsx":"7","/home/klokev20/headlamp-plugins/kubevirt/src/kubevirt/VirtualMachines/List.tsx":"8","/home/klokev20/headlamp-plugins/kubevirt/src/kubevirt/VirtualMachines/VirtualMachine.tsx":"9","/home/klokev20/headlamp-plugins/kubevirt/src/storybook.test.tsx":"10"},{"size":680,"mtime":1762330749267,"results":"11","hashOfConfig":"12"},{"size":1575,"mtime":1762333810208,"results":"13","hashOfConfig":"12"},{"size":7407,"mtime":1762330749267,"results":"14","hashOfConfig":"12"},{"size":2486,"mtime":1762330749267,"results":"15","hashOfConfig":"12"},{"size":3772,"mtime":1762334239548,"results":"16","hashOfConfig":"12"},{"size":1180,"mtime":1762330749267,"results":"17","hashOfConfig":"12"},{"size":5301,"mtime":1762330749267,"results":"18","hashOfConfig":"12"},{"size":3379,"mtime":1762334402395,"results":"19","hashOfConfig":"12"},{"size":1203,"mtime":1762330749267,"results":"20","hashOfConfig":"12"},{"size":176,"mtime":1762330749267,"results":"21","hashOfConfig":"12"},{"filePath":"22","messages":"23","suppressedMessages":"24","errorCount":0,"fatalErrorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0},"1o2l0oj",{"filePath":"25","messages":"26","suppressedMessages":"27","errorCount":0,"fatalErrorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0},{"filePath":"28","messages":"29","suppressedMessages":"30","errorCount":0,"fatalErrorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0},{"filePath":"31","messages":"32","suppressedMessages":"33","errorCount":0,"fatalErrorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0},{"filePath":"34","messages":"35","suppressedMessages":"36","errorCount":0,"fatalErrorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0},{"filePath":"37","messages":"38","suppressedMessages":"39","errorCount":0,"fatalErrorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0},{"filePath":"40","messages":"41","suppressedMessages":"42","errorCount":0,"fatalErrorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0},{"filePath":"43","messages":"44","suppressedMessages":"45","errorCount":0,"fatalErrorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0},{"filePath":"46","messages":"47","suppressedMessages":"48","errorCount":0,"fatalErrorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0},{"filePath":"49","messages":"50","suppressedMessages":"51","errorCount":0,"fatalErrorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0},"/home/klokev20/headlamp-plugins/kubevirt/src/headlamp-plugin.d.ts",[],[],"/home/klokev20/headlamp-plugins/kubevirt/src/index.tsx",[],[],"/home/klokev20/headlamp-plugins/kubevirt/src/kubevirt/Terminal/Terminal.tsx",[],[],"/home/klokev20/headlamp-plugins/kubevirt/src/kubevirt/VirtualMachineInstance/Details.tsx",[],[],"/home/klokev20/headlamp-plugins/kubevirt/src/kubevirt/VirtualMachineInstance/List.tsx",[],[],"/home/klokev20/headlamp-plugins/kubevirt/src/kubevirt/VirtualMachineInstance/VirtualMachineInstance.tsx",[],[],"/home/klokev20/headlamp-plugins/kubevirt/src/kubevirt/VirtualMachines/Details.tsx",[],[],"/home/klokev20/headlamp-plugins/kubevirt/src/kubevirt/VirtualMachines/List.tsx",[],[],"/home/klokev20/headlamp-plugins/kubevirt/src/kubevirt/VirtualMachines/VirtualMachine.tsx",[],[],"/home/klokev20/headlamp-plugins/kubevirt/src/storybook.test.tsx",[],[]]
1+
[{"/home/klokev20/headlamp-plugins/kubevirt/src/headlamp-plugin.d.ts":"1","/home/klokev20/headlamp-plugins/kubevirt/src/index.tsx":"2","/home/klokev20/headlamp-plugins/kubevirt/src/kubevirt/Terminal/Terminal.tsx":"3","/home/klokev20/headlamp-plugins/kubevirt/src/kubevirt/VirtualMachineInstance/Details.tsx":"4","/home/klokev20/headlamp-plugins/kubevirt/src/kubevirt/VirtualMachineInstance/List.tsx":"5","/home/klokev20/headlamp-plugins/kubevirt/src/kubevirt/VirtualMachineInstance/VirtualMachineInstance.tsx":"6","/home/klokev20/headlamp-plugins/kubevirt/src/kubevirt/VirtualMachines/Details.tsx":"7","/home/klokev20/headlamp-plugins/kubevirt/src/kubevirt/VirtualMachines/List.tsx":"8","/home/klokev20/headlamp-plugins/kubevirt/src/kubevirt/VirtualMachines/VirtualMachine.tsx":"9","/home/klokev20/headlamp-plugins/kubevirt/src/storybook.test.tsx":"10"},{"size":680,"mtime":1762503095333,"results":"11","hashOfConfig":"12"},{"size":1575,"mtime":1762503095333,"results":"13","hashOfConfig":"12"},{"size":7407,"mtime":1762503095334,"results":"14","hashOfConfig":"12"},{"size":2486,"mtime":1762503095334,"results":"15","hashOfConfig":"12"},{"size":3772,"mtime":1762503095334,"results":"16","hashOfConfig":"12"},{"size":1636,"mtime":1762503095334,"results":"17","hashOfConfig":"12"},{"size":12115,"mtime":1762506539559,"results":"18","hashOfConfig":"12"},{"size":3379,"mtime":1762503095334,"results":"19","hashOfConfig":"12"},{"size":2172,"mtime":1762505239094,"results":"20","hashOfConfig":"12"},{"size":176,"mtime":1762503095334,"results":"21","hashOfConfig":"12"},{"filePath":"22","messages":"23","suppressedMessages":"24","errorCount":0,"fatalErrorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0},"1o2l0oj",{"filePath":"25","messages":"26","suppressedMessages":"27","errorCount":0,"fatalErrorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0},{"filePath":"28","messages":"29","suppressedMessages":"30","errorCount":0,"fatalErrorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0},{"filePath":"31","messages":"32","suppressedMessages":"33","errorCount":0,"fatalErrorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0},{"filePath":"34","messages":"35","suppressedMessages":"36","errorCount":0,"fatalErrorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0},{"filePath":"37","messages":"38","suppressedMessages":"39","errorCount":0,"fatalErrorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0},{"filePath":"40","messages":"41","suppressedMessages":"42","errorCount":1,"fatalErrorCount":1,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0,"source":null},{"filePath":"43","messages":"44","suppressedMessages":"45","errorCount":0,"fatalErrorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0},{"filePath":"46","messages":"47","suppressedMessages":"48","errorCount":0,"fatalErrorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0},{"filePath":"49","messages":"50","suppressedMessages":"51","errorCount":0,"fatalErrorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0},"/home/klokev20/headlamp-plugins/kubevirt/src/headlamp-plugin.d.ts",[],[],"/home/klokev20/headlamp-plugins/kubevirt/src/index.tsx",[],[],"/home/klokev20/headlamp-plugins/kubevirt/src/kubevirt/Terminal/Terminal.tsx",[],[],"/home/klokev20/headlamp-plugins/kubevirt/src/kubevirt/VirtualMachineInstance/Details.tsx",[],[],"/home/klokev20/headlamp-plugins/kubevirt/src/kubevirt/VirtualMachineInstance/List.tsx",[],[],"/home/klokev20/headlamp-plugins/kubevirt/src/kubevirt/VirtualMachineInstance/VirtualMachineInstance.tsx",[],[],"/home/klokev20/headlamp-plugins/kubevirt/src/kubevirt/VirtualMachines/Details.tsx",["52"],[],"/home/klokev20/headlamp-plugins/kubevirt/src/kubevirt/VirtualMachines/List.tsx",[],[],"/home/klokev20/headlamp-plugins/kubevirt/src/kubevirt/VirtualMachines/VirtualMachine.tsx",[],[],"/home/klokev20/headlamp-plugins/kubevirt/src/storybook.test.tsx",[],[],{"ruleId":null,"fatal":true,"severity":2,"message":"53","line":160,"column":6,"nodeType":null},"Parsing error: ':' expected."]

‎kubevirt/src/kubevirt/VirtualMachines/Details.tsx‎

Lines changed: 193 additions & 62 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
import { ApiProxy } from '@kinvolk/headlamp-plugin/lib';
22
import { Link, Resource } from '@kinvolk/headlamp-plugin/lib/components/common';
33
import { ActionButton } from '@kinvolk/headlamp-plugin/lib/components/common';
4+
import { Chip } from '@mui/material';
45
import { useSnackbar } from 'notistack';
56
import { useEffect, useState } from 'react';
67
import { useTranslation } from 'react-i18next';
@@ -22,76 +23,163 @@ export default function VirtualMachineDetails(props: VirtualMachineDetailsProps)
2223
const [showTerminal, setShowTerminal] = useState(false);
2324

2425
const [podName, setPodName] = useState<string | null>(null);
26+
const [nodeName, setNodeName] = useState<string | null>(null);
2527
useEffect(() => {
26-
const fetchPodName = async () => {
28+
const fetchInitial = async () => {
2729
try {
28-
const podName = await getPodName(name, namespace);
29-
setPodName(podName);
30+
const info = await getPodInfo(name, namespace);
31+
setPodName(info.podName);
32+
setNodeName(info.nodeName);
3033
} catch (error) {
31-
console.error('Failed to get pod name', error);
34+
console.error('Failed to get pod info', error);
3235
}
3336
};
3437

35-
fetchPodName();
38+
fetchInitial();
39+
40+
const queryParams = new URLSearchParams();
41+
queryParams.append('labelSelector', `vm.kubevirt.io/name=${name}`);
42+
queryParams.append('watch', 'true');
43+
const url = `/api/v1/namespaces/${namespace}/pods?${queryParams.toString()}`;
44+
45+
const onStream = (result, disconnect, error) => {
46+
if (error) {
47+
console.error('Stream error:', error);
48+
disconnect();
49+
return;
50+
}
51+
52+
const event = result;
53+
if (event.type === 'ADDED' || event.type === 'MODIFIED') {
54+
const pod = event.object;
55+
setPodName(pod.metadata.name);
56+
setNodeName(pod.spec.nodeName || 'Unknown');
57+
} else if (event.type === 'DELETED') {
58+
setPodName('Unknown');
59+
setNodeName('Unknown');
60+
}
61+
};
62+
63+
const { cancel: cancelPod } = ApiProxy.stream(url, onStream, { isJson: true });
64+
65+
// Watch for events
66+
const eventQueryParams = new URLSearchParams();
67+
eventQueryParams.append('watch', 'true');
68+
eventQueryParams.append(
69+
'fieldSelector',
70+
`involvedObject.name=${name},involvedObject.kind=VirtualMachine,involvedObject.namespace=${namespace}`
71+
);
72+
const eventUrl = `/api/v1/namespaces/${namespace}/events?${eventQueryParams.toString()}`;
73+
74+
const onEventStream = (result, disconnect, error) => {
75+
if (error) {
76+
console.error('Event stream error:', error);
77+
disconnect();
78+
return;
79+
}
80+
81+
const event = result;
82+
if (event.type === 'ADDED') {
83+
setEvents(prevEvents => {
84+
const newEvents = [...prevEvents, event.object];
85+
newEvents.sort(
86+
(a, b) => new Date(b.lastTimestamp).getTime() - new Date(a.lastTimestamp).getTime()
87+
);
88+
return newEvents;
89+
});
90+
}
91+
};
92+
93+
const { cancel: cancelEvent } = ApiProxy.stream(eventUrl, onEventStream, { isJson: true });
94+
95+
return () => {
96+
cancelPod();
97+
cancelEvent();
98+
};
3699
}, [name, namespace]);
37100
return (
38101
<Resource.DetailsGrid
39102
name={name}
40103
namespace={namespace}
41104
resourceType={VirtualMachine}
105+
withEvents
42106
extraInfo={item =>
43-
item && [
44-
{
45-
name: t('Status'),
46-
value: item?.jsonData.status.printableStatus,
47-
},
48-
{
49-
name: 'VirtualMachineInstance',
50-
value: (
51-
<Link
52-
routeName="/kubevirt/virtualmachinesinstances/:namespace/:name"
53-
params={{ name: item.getName(), namespace: item.getNamespace() }}
54-
>
55-
{item.getName()}
56-
</Link>
57-
),
58-
},
59-
{
60-
name: 'Pod',
61-
value: (
62-
<Link
63-
routeName="pod"
64-
params={{
65-
name: podName,
66-
namespace: item.getNamespace(),
67-
}}
68-
>
69-
{podName}
70-
</Link>
71-
),
72-
},
73-
]
107+
item
108+
? [
109+
{
110+
name: t('Status'),
111+
value: (
112+
<Chip
113+
label={item?.jsonData.status.printableStatus || 'Unknown'}
114+
color={getStatusColor(item?.jsonData.status.printableStatus || 'Unknown')}
115+
variant="outlined"
116+
/>
117+
),
118+
},
119+
{
120+
name: 'VirtualMachineInstance',
121+
value: (
122+
<Link
123+
routeName="/kubevirt/virtualmachinesinstances/:namespace/:name"
124+
params={{ name: item.getName(), namespace: item.getNamespace() }}
125+
>
126+
{item.getName()}
127+
</Link>
128+
),
129+
},
130+
{
131+
name: 'Pod',
132+
value:
133+
podName && podName !== 'Unknown' ? (
134+
<Link
135+
routeName="pod"
136+
params={{
137+
name: podName,
138+
namespace: item.getNamespace(),
139+
}}
140+
>
141+
{podName}
142+
</Link>
143+
) : (
144+
'Unknown'
145+
),
146+
},
147+
{
148+
name: 'Node',
149+
value:
150+
nodeName && nodeName !== 'Unknown' ? (
151+
<Link routeName="node" params={{ name: nodeName }}>
152+
{nodeName}
153+
</Link>
154+
) : (
155+
'Unknown'
156+
),
157+
},
158+
]
159+
: null
74160
}
75161
extraSections={item =>
76-
item && [
77-
{
78-
id: 'status',
79-
section: <Resource.ConditionsSection resource={item?.jsonData} />,
80-
},
81-
{
82-
id: 'headlamp.vm-terminal',
83-
section: (
84-
<Terminal
85-
open={showTerminal}
86-
key="terminal"
87-
item={item}
88-
onClose={() => {
89-
setShowTerminal(false);
90-
}}
91-
/>
92-
),
93-
},
94-
]
162+
item
163+
? [
164+
{
165+
id: 'status',
166+
section: <Resource.ConditionsSection resource={item?.jsonData} />,
167+
},
168+
{
169+
id: 'headlamp.vm-terminal',
170+
section: (
171+
<Terminal
172+
open={showTerminal}
173+
key="terminal"
174+
item={item}
175+
onClose={() => {
176+
setShowTerminal(false);
177+
}}
178+
/>
179+
),
180+
},
181+
]
182+
: null
95183
}
96184
actions={item => {
97185
if (!item) return [];
@@ -179,6 +267,30 @@ export default function VirtualMachineDetails(props: VirtualMachineDetailsProps)
179267
});
180268
}
181269

270+
if (isRunning) {
271+
actionsList.push({
272+
id: 'migrate',
273+
action: (
274+
<ActionButton
275+
description={t('Live Migrate')}
276+
icon="mdi:swap-horizontal"
277+
onClick={() => {
278+
console.log('Starting live migration for ' + item.getName());
279+
item
280+
.migrate()
281+
.then(() => {
282+
enqueueSnackbar(t('Live migration initiated'), { variant: 'success' });
283+
})
284+
.catch(e => {
285+
console.error('Migration failed', e);
286+
enqueueSnackbar(t('Failed to initiate live migration'), { variant: 'error' });
287+
});
288+
}}
289+
/>
290+
),
291+
});
292+
}
293+
182294
if (isPaused) {
183295
actionsList.push({
184296
id: 'unpause',
@@ -227,17 +339,36 @@ export default function VirtualMachineDetails(props: VirtualMachineDetailsProps)
227339
);
228340
}
229341

230-
async function getPodName(name: string, namespace: string): Promise<string> {
342+
function getStatusColor(status: string) {
343+
if (status === 'Running') return 'success';
344+
if (status === 'Failed') return 'error';
345+
if (['Migrating', 'Starting', 'Stopping'].includes(status)) return 'warning';
346+
return 'default';
347+
}
348+
349+
async function getPodInfo(
350+
name: string,
351+
namespace: string
352+
): Promise<{ podName: string; nodeName: string }> {
231353
const request = ApiProxy.request;
232354
const queryParams = new URLSearchParams();
233-
let response;
234355
queryParams.append('labelSelector', `vm.kubevirt.io/name=${name}`);
235356
try {
236-
response = await request(`/api/v1/namespaces/${namespace}/pods?${queryParams.toString()}`, {
237-
method: 'GET',
238-
});
357+
const response = await request(
358+
`/api/v1/namespaces/${namespace}/pods?${queryParams.toString()}`,
359+
{
360+
method: 'GET',
361+
}
362+
);
363+
const pod = response?.items[0];
364+
if (pod) {
365+
return {
366+
podName: pod.metadata.name,
367+
nodeName: pod.spec.nodeName || 'Unknown',
368+
};
369+
}
370+
return { podName: 'Unknown', nodeName: 'Unknown' };
239371
} catch (error) {
240-
return 'Unknown';
372+
return { podName: 'Unknown', nodeName: 'Unknown' };
241373
}
242-
return response?.items[0]?.metadata?.name || 'Unknown';
243374
}

‎kubevirt/src/kubevirt/VirtualMachines/VirtualMachine.tsx‎

Lines changed: 33 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
1-
import { StreamArgs, StreamResultsCb } from '@kinvolk/headlamp-plugin/lib/ApiProxy';
1+
import ApiProxy, { StreamArgs, StreamResultsCb } from '@kinvolk/headlamp-plugin/lib/ApiProxy';
22
import { KubeObject } from '@kinvolk/headlamp-plugin/lib/K8s/cluster';
33
import VirtualMachineInstance from '../VirtualMachineInstance/VirtualMachineInstance';
44

55
class VirtualMachine extends KubeObject {
6-
constructor(jsonData) {
6+
constructor(jsonData: any) {
77
super(jsonData);
88
}
99

@@ -49,6 +49,37 @@ class VirtualMachine extends KubeObject {
4949
return instance.unpause();
5050
}
5151

52+
async migrate() {
53+
const migrationName = `${this.getName()}-migration-${Date.now()}`;
54+
const migration = {
55+
apiVersion: 'kubevirt.io/v1',
56+
kind: 'VirtualMachineInstanceMigration',
57+
metadata: {
58+
name: migrationName,
59+
namespace: this.getNamespace(),
60+
},
61+
spec: {
62+
vmiName: this.getName(),
63+
},
64+
};
65+
66+
try {
67+
await ApiProxy.request(
68+
`/apis/kubevirt.io/v1/namespaces/${this.getNamespace()}/virtualmachineinstancemigrations`,
69+
{
70+
method: 'POST',
71+
body: JSON.stringify(migration),
72+
headers: {
73+
'Content-Type': 'application/json',
74+
},
75+
}
76+
);
77+
return migrationName;
78+
} catch (error) {
79+
throw error;
80+
}
81+
}
82+
5283
static kind = 'VirtualMachine';
5384
static apiVersion = 'kubevirt.io/v1';
5485
static isNamespaced = true;

0 commit comments

Comments
 (0)