fix(auth): improve error handling for disabling password authentication

Ubisoft-potato · Ubisoft-potato · commit 64026d447aa0 · 2025-09-30T10:35:41.000+08:00
diff --git a/pkg/environment/command/organization.go b/pkg/environment/command/organization.go
@@ -98,7 +98,8 @@ func (h *organizationCommandHandler) changePasswordAuthentication(
 	if cmd.PasswordAuthenticationEnabled {
 		h.organization.EnableAuthenticationType(proto.AuthenticationType_AUTHENTICATION_TYPE_PASSWORD)
 	} else {
-		if err := h.organization.DisableAuthenticationType(proto.AuthenticationType_AUTHENTICATION_TYPE_PASSWORD); err != nil {
+		err := h.organization.DisableAuthenticationType(proto.AuthenticationType_AUTHENTICATION_TYPE_PASSWORD)
+		if err != nil {
 			return err
 		}
 	}

Original file line number	Diff line number	Diff line change
`@@ -98,7 +98,8 @@ func (h *organizationCommandHandler) changePasswordAuthentication(`
`98`	`98`	`if cmd.PasswordAuthenticationEnabled {`
`99`	`99`	`h.organization.EnableAuthenticationType(proto.AuthenticationType_AUTHENTICATION_TYPE_PASSWORD)`
`100`	`100`	`} else {`
`101`		`- if err := h.organization.DisableAuthenticationType(proto.AuthenticationType_AUTHENTICATION_TYPE_PASSWORD); err != nil {`
	`101`	`+ err := h.organization.DisableAuthenticationType(proto.AuthenticationType_AUTHENTICATION_TYPE_PASSWORD)`
	`102`	`+ if err != nil {`
`102`	`103`	`return err`
`103`	`104`	`}`
`104`	`105`	`}`