Add a param for #theme

jpolitz · jpolitz · commit 8c9647721b3c · 2025-06-16T12:33:02.000-07:00
This allows embedders to control the theme. The hash param theme overrides the
user setting, but does not change the stored user setting.

The related change in CPO controls this – instead of eagerly changing the user
setting to the set param value, instead let them differ until the user
explicitly changes it with a UI action.
diff --git a/src/web/editor.html b/src/web/editor.html
@@ -29,9 +29,6 @@
 </head>
 <body class="default">
   <script>
-    var themeOnLoad = localSettings.getItem('theme') || 'default';
-    document.body.classList.remove("default");
-    document.body.classList.add(themeOnLoad);
     var optionalTemplatedHash = "{{ &HASH_OPTIONS }}";
     var params = {};
     let hash;
@@ -70,6 +67,13 @@
     default:
       // nothing to do
     }
+
+    var themeOnLoad = params['theme'] || localSettings.getItem('theme') || 'default';
+    document.body.classList.remove("default");
+    document.body.classList.add(themeOnLoad);
+
+    console.log("Theme info", String(document.body.classList), themeOnLoad, params, localSettings.getItem('theme'));
+
     window.addEventListener('load', function() {
       document.getElementById('theme-select').value = themeOnLoad;
     }, { once: true });
diff --git a/src/web/js/cpo-main.js b/src/web/js/cpo-main.js
@@ -593,11 +593,7 @@
         curTheme = theme;
       }
 
-      if (localSettings.getItem('theme') !== null) {
-        applyTheme(localSettings.getItem('theme'));
-      } else {
-        localSettings.setItem('theme', curTheme);
-      }
+      applyTheme(curTheme);
 
       $("#theme").change(function(e) {
         var value = e.target.value;
diff --git a/src/web/js/trove/chart-lib.js b/src/web/js/trove/chart-lib.js
@@ -1,4 +1,5 @@
 ({
+
   requires: [
     { 'import-type': 'builtin', 'name': 'image-lib' },
   ],

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,5 @@`
`1`	`1`	`({`
	`2`	`+`
`2`	`3`	`requires: [`
`3`	`4`	`{ 'import-type': 'builtin', 'name': 'image-lib' },`
`4`	`5`	`],`