Skip to content

Commit d8e4a9e

Browse files
committed
PHPStan level max
1 parent eeaeea9 commit d8e4a9e

File tree

6 files changed

+27
-9
lines changed

6 files changed

+27
-9
lines changed

.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
11
/vendor/
22
composer.lock
33
.php_cs.cache
4+
.phpunit.result.cache

Makefile

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ test:
1010
vendor/bin/phpunit --testdox --colors=always --group=functional
1111

1212
.PHONY: qa
13-
qa: php-cs-fixer-ci
13+
qa: php-cs-fixer-ci phpstan
1414

1515
.PHONY: php-cs-fixer
1616
php-cs-fixer:
@@ -20,6 +20,10 @@ php-cs-fixer:
2020
php-cs-fixer-ci:
2121
vendor/bin/php-cs-fixer fix --dry-run --no-interaction --allow-risky=yes --diff --verbose
2222

23+
PHONY: phpstan
24+
phpstan:
25+
vendor/bin/phpstan analyse --level=max src/
26+
2327
.PHONY: changelog
2428
changelog:
2529
git log $$(git describe --abbrev=0 --tags)...HEAD --no-merges --pretty=format:"* [%h](http://github.com/${TRAVIS_REPO_SLUG}/commit/%H) %s (%cN)"

composer.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,8 @@
3535
],
3636
"require-dev": {
3737
"phpunit/phpunit": "^8.0",
38-
"broadway/coding-standard": "^1.0"
38+
"broadway/coding-standard": "^1.0",
39+
"phpstan/phpstan": "@stable"
3940
},
4041
"autoload": {
4142
"psr-4": {

phpstan.neon

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
parameters:
2+
checkMissingIterableValueType: false

src/ElasticSearchRepository.php

Lines changed: 14 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -25,10 +25,19 @@
2525
*/
2626
class ElasticSearchRepository implements Repository
2727
{
28+
/** @var Client */
2829
private $client;
30+
31+
/** @var Serializer */
2932
private $serializer;
33+
34+
/** @var string */
3035
private $index;
36+
37+
/** @var string */
3138
private $class;
39+
40+
/** @var string[] */
3241
private $notAnalyzedFields;
3342

3443
public function __construct(
@@ -121,7 +130,7 @@ public function remove($id): void
121130
}
122131
}
123132

124-
private function searchAndDeserializeHits(array $query)
133+
private function searchAndDeserializeHits(array $query): array
125134
{
126135
try {
127136
$result = $this->client->search($query);
@@ -153,7 +162,7 @@ protected function search(array $query, array $facets = [], int $size = 500): ar
153162
}
154163
}
155164

156-
protected function query(array $query)
165+
protected function query(array $query): array
157166
{
158167
return $this->searchAndDeserializeHits(
159168
[
@@ -183,7 +192,7 @@ private function buildFindAllQuery(): array
183192
];
184193
}
185194

186-
private function deserializeHit(array $hit)
195+
private function deserializeHit(array $hit): Identifiable
187196
{
188197
return $this->serializer->deserialize(
189198
[
@@ -193,12 +202,12 @@ private function deserializeHit(array $hit)
193202
);
194203
}
195204

196-
private function deserializeHits(array $hits)
205+
private function deserializeHits(array $hits): array
197206
{
198207
return array_map([$this, 'deserializeHit'], $hits);
199208
}
200209

201-
private function buildFilter(array $filter)
210+
private function buildFilter(array $filter): array
202211
{
203212
$retval = [];
204213

@@ -247,8 +256,6 @@ public function createIndex(): bool
247256

248257
/**
249258
* Deletes the index for this repository's ReadModel.
250-
*
251-
* @return True, if the index was successfully deleted
252259
*/
253260
public function deleteIndex(): bool
254261
{

src/ElasticSearchRepositoryFactory.php

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,10 @@
2323
*/
2424
class ElasticSearchRepositoryFactory implements RepositoryFactory
2525
{
26+
/** @var Client */
2627
private $client;
28+
29+
/** @var Serializer */
2730
private $serializer;
2831

2932
public function __construct(Client $client, Serializer $serializer)

0 commit comments

Comments
 (0)