Skip to content

Commit bfb9260

Browse files
committed
comment out branch trigger in minify_ontologies.yml
fix error in uniquefied name splitting
1 parent ba4f244 commit bfb9260

File tree

4 files changed

+8
-7
lines changed

4 files changed

+8
-7
lines changed

.github/workflows/minify_ontologies.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,9 @@ name: Minify ontologies
33
on:
44
pull_request:
55
types: [opened] # Only trigger on PR "opened" event
6-
push: # Uncomment, update branches to develop / debug
7-
branches:
8-
jlc_show_gene_name
6+
# push: # Uncomment, update branches to develop / debug
7+
# branches:
8+
# jlc_show_gene_name
99

1010
jobs:
1111
build:

ingest/de.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -309,8 +309,9 @@ def delimiter_in_gene_name(rank):
309309
@staticmethod
310310
def extract_gene_id_for_out_file(rank):
311311
"""Separate out gene name from gene ID"""
312-
rank['names'] = rank['names'].str.split('|').str[0]
313312
rank['feature_id'] = rank['names'].str.split('|').str[1]
313+
rank['names'] = rank['names'].str.split('|').str[0]
314+
314315
return rank
315316

316317
@staticmethod
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
names scores logfoldchanges pvals pvals_adj pct_nz_group pct_nz_reference feature_id
2-
0 Sox17 41.46 11.63 0 0 0.4833 0.002793
3-
1 Sox17 -5.059 -0.8853 4.225e-07 4.225e-07 0.1514 0.1939
2+
0 Sox17 41.46 11.63 0 0 0.4833 0.002793 ENSMUST00000027035
3+
1 Sox17 -5.059 -0.8853 4.225e-07 4.225e-07 0.1514 0.1939 ENSMUST00000195555

tests/test_de.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -375,7 +375,7 @@ def test_de_process_sparse(self):
375375
self.assertIn('feature_id', content.columns, "Expected feature_id output not found.")
376376

377377
# md5 checksum calculated using reference file in tests/data/differential_expression/sparse/reference
378-
expected_checksum = "2129b3f6f0c7ee56ab2b6a74948c46a7"
378+
expected_checksum = "7b13cb24b020aca268015e714ca2d666"
379379

380380
# running DifferentialExpression via pytest results in output files in the tests dir
381381
with open(expected_file_path, "rb") as f:

0 commit comments

Comments
 (0)