Skip to content

Commit d5d6ea2

Browse files
committed
feat(frontend): clearly list variants not included in calculations
1 parent abb669c commit d5d6ea2

File tree

1 file changed

+38
-4
lines changed

1 file changed

+38
-4
lines changed

frontend/src/components/VariantListPage/VariantListVariants.tsx

Lines changed: 38 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ import {
44
Button,
55
Checkbox,
66
HStack,
7+
List,
78
ListItem,
89
Text,
910
Tooltip,
@@ -32,6 +33,7 @@ import {
3233
import MultipleSelect from "../MultipleSelect";
3334
import { DownloadVariantListLink } from "./DownloadVariantList";
3435
import VariantsTable from "./VariantsTable";
36+
import HelpTextHover from "../HelpTextHover";
3537

3638
export const combineVariants = (
3739
variants: Variant[],
@@ -181,16 +183,48 @@ const VariantListVariants = (props: VariantListVariantsProps) => {
181183
(variant) => (variant.AC || [])[0] === 0
182184
).length;
183185

186+
const unselectedVariants = renderedVariants.filter(
187+
(variant) => !selectedVariants.has(variant.id)
188+
);
189+
const neverIncludedVariants = renderedVariants.filter((variant) =>
190+
notIncludedVariants.has(variant.id)
191+
);
192+
193+
const unselectedVariantsTooltip = (
194+
<>
195+
<Text>Currently unselected variants:</Text>
196+
<List>
197+
{unselectedVariants
198+
.filter((variant) => !notIncludedVariants.has(variant.id))
199+
.map((variant) => {
200+
return <ListItem pl={"2"}>{variant.id}</ListItem>;
201+
})}
202+
</List>
203+
<Text>Currently fully excluded variants:</Text>
204+
<List>
205+
{neverIncludedVariants.map((variant) => {
206+
return <ListItem pl={"2"}>{variant.id}</ListItem>;
207+
})}
208+
</List>
209+
</>
210+
);
211+
184212
return (
185213
<>
186214
<Text mb={2}>
187215
This variant list contains {renderedVariants.length} variant
188216
{variantList.variants.length !== 1 ? "s" : ""}.
189217
</Text>
190-
<Text mb={2}>
191-
{notIncludedVariants.size} variant
192-
{notIncludedVariants.size !== 1 ? "s" : ""} are not included.
193-
</Text>
218+
{unselectedVariants.length > 0 && (
219+
<>
220+
<Text mb={2}>
221+
{unselectedVariants.length} variant
222+
{unselectedVariants.length !== 1 ? "s are" : " is"} not currently
223+
not included in calculations.{" "}
224+
<HelpTextHover helpText={unselectedVariantsTooltip} />
225+
</Text>
226+
</>
227+
)}
194228

195229
{variantList.status === "Ready" ? (
196230
<>

0 commit comments

Comments
 (0)