remove 2>&1 from perf stat to display errors #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great PRs. I found the error by removing this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redirecting stderr to stdout causes perf errors to be redirected to awk as normal stdin input. Then, awk silently discards them. This makes it hard to troubleshoot issues like unavailable counters or system configuration.
I had to remove '2>&1' manually from all scripts to troubleshoot silent termination with no errors. Turns out one metric was not available for my system and that causes 'perf stat' to terminate immediately. I think there's no reason to silence errors. When the script works fine, there's no error output and it works equally well.