Skip to content

Commit 86fbc74

Browse files
[cr144] SSLInfo arg added to TrustedHeaderClient
This affects the override we have, however there is no use for this argument in our use-case. Chromium changes: https://chromium.googlesource.com/chromium/src/+/c62fa5cbaa4542755128cda06cfd1ea813e41103 commit c62fa5cbaa4542755128cda06cfd1ea813e41103 Author: Vlad Krot <[email protected]> Date: Thu Nov 6 03:07:35 2025 -0800 Add ssl info to TrustedHeaderClient This change allows to get ssl_info in TrustedHeaderClient, which is used by url_loader and web_socket. The change won't impact performance of url_loader or web_socket, that does not use trusted_headers_client, which is only used in two places, and this is where ssl_info is needed for extensions api in future: extensions/browser/api/web_request/web_request_proxying_websocket.cc extensions/browser/api/web_request/web_request_proxying_url_loader_factory.cc Extensions proposal: w3c/webextensions#899 Isolated Web App API proposal: explainers-by-googlers/security-info-web-request#1 I have added low coverage reason because websocket.cc is not tested via unit tests, but with chrome/browser/net/websocket_browsertest.cc. It is out of scope of my CL to investigate why unit tests are absent for websocket.cc. Change-Id: I40f0fcb40db7a5efeaaf18276d6cc9bf6c7b48e3 Bug: 458045659 Low-Coverage-Reason: HARD_TO_TEST Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7106780 Reviewed-by: Adam Rice <[email protected]> Reviewed-by: Arthur Sonzogni <[email protected]> Reviewed-by: Finnur Thorarinsson <[email protected]> Reviewed-by: Andrew Rayskiy <[email protected]> Commit-Queue: Vlad Krot <[email protected]> Cr-Commit-Position: refs/heads/main@{#1541131}
1 parent 946074a commit 86fbc74

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

browser/net/brave_proxying_web_socket.cc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -220,6 +220,7 @@ void BraveProxyingWebSocket::OnBeforeSendHeaders(
220220
void BraveProxyingWebSocket::OnHeadersReceived(
221221
const std::string& headers,
222222
const ::net::IPEndPoint& remote_endpoint,
223+
const std::optional<net::SSLInfo>& ssl_info,
223224
OnHeadersReceivedCallback callback) {
224225
DCHECK(proxy_has_extra_headers());
225226

@@ -368,8 +369,7 @@ void BraveProxyingWebSocket::OnHeadersReceivedComplete(int error_code) {
368369

369370
if (proxy_has_extra_headers()) {
370371
proxy_trusted_header_client_->OnHeadersReceived(
371-
headers,
372-
remote_endpoint_,
372+
headers, remote_endpoint_, /*ssl_info=*/std::nullopt,
373373
base::BindOnce(
374374
&BraveProxyingWebSocket::OnHeadersReceivedCompleteFromProxy,
375375
weak_factory_.GetWeakPtr()));

browser/net/brave_proxying_web_socket.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -94,6 +94,7 @@ class BraveProxyingWebSocket
9494
OnBeforeSendHeadersCallback callback) override;
9595
void OnHeadersReceived(const std::string& headers,
9696
const ::net::IPEndPoint& remote_endpoint,
97+
const std::optional<net::SSLInfo>& ssl_info,
9798
OnHeadersReceivedCallback callback) override;
9899

99100
private:

0 commit comments

Comments
 (0)