Commit 86fbc74
committed
[cr144]
This affects the override we have, however there is no use for this
argument in our use-case.
Chromium changes:
https://chromium.googlesource.com/chromium/src/+/c62fa5cbaa4542755128cda06cfd1ea813e41103
commit c62fa5cbaa4542755128cda06cfd1ea813e41103
Author: Vlad Krot <[email protected]>
Date: Thu Nov 6 03:07:35 2025 -0800
Add ssl info to TrustedHeaderClient
This change allows to get ssl_info in TrustedHeaderClient, which is used
by url_loader and web_socket. The change won't impact performance of
url_loader or web_socket, that does not use trusted_headers_client,
which is only used in two places, and this is where ssl_info is needed
for extensions api in future:
extensions/browser/api/web_request/web_request_proxying_websocket.cc
extensions/browser/api/web_request/web_request_proxying_url_loader_factory.cc
Extensions proposal: w3c/webextensions#899
Isolated Web App API proposal:
explainers-by-googlers/security-info-web-request#1
I have added low coverage reason because websocket.cc is not tested via
unit tests, but with chrome/browser/net/websocket_browsertest.cc. It is
out of scope of my CL to investigate why unit tests are absent for
websocket.cc.
Change-Id: I40f0fcb40db7a5efeaaf18276d6cc9bf6c7b48e3
Bug: 458045659
Low-Coverage-Reason: HARD_TO_TEST
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7106780
Reviewed-by: Adam Rice <[email protected]>
Reviewed-by: Arthur Sonzogni <[email protected]>
Reviewed-by: Finnur Thorarinsson <[email protected]>
Reviewed-by: Andrew Rayskiy <[email protected]>
Commit-Queue: Vlad Krot <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1541131}SSLInfo arg added to TrustedHeaderClient
1 parent 946074a commit 86fbc74
File tree
2 files changed
+3
-2
lines changed- browser/net
2 files changed
+3
-2
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
220 | 220 | | |
221 | 221 | | |
222 | 222 | | |
| 223 | + | |
223 | 224 | | |
224 | 225 | | |
225 | 226 | | |
| |||
368 | 369 | | |
369 | 370 | | |
370 | 371 | | |
371 | | - | |
372 | | - | |
| 372 | + | |
373 | 373 | | |
374 | 374 | | |
375 | 375 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
94 | 94 | | |
95 | 95 | | |
96 | 96 | | |
| 97 | + | |
97 | 98 | | |
98 | 99 | | |
99 | 100 | | |
| |||
0 commit comments