Skip to content

Conversation

@Flamefire
Copy link
Contributor

source_group(TREE requires CMake 3.8

@vinniefalco
Copy link
Member

CI did not like this !

@Flamefire
Copy link
Contributor Author

Flamefire commented Oct 1, 2025

CI seems to be broken unrelated to this change. It doesn't even have the workaround for the node issue that most other libraries have by now.

It would be good to move this to the Boost.CI reusable workflow, see #64 and fix the tests broken on C++2c

@vinniefalco
Copy link
Member

If there is a more modern CI workflow, yes. Is this the one that Alan wrote all the scripts for?

@Flamefire
Copy link
Contributor Author

The switch now happened with #64

It is using the scripts from the Boost.CI repository and the commonized workflow written by James such that updates can happen in a central place instead of having to duplicate changes over all repositories.

Why scripts did you refer too?

@vinniefalco
Copy link
Member

@alandefreitas wrote a pretty beefy set of things for GHA. Not sure how it ties in to Boost.CI. Alan?

@alandefreitas
Copy link
Member

Alan?

My cpp-actions project provides individual steps with GHA that you can combine to form a generic workflow. Since then, boost-ci has started providing a more fixed, reusable workflow for boost libraries. It's a trade-off that depends on whether your library has special variants that need to be tested.

Boost.StaticString moved to this boost-ci reusable work (#64), and I believe it's appropriate for this project. My only concern is that the reusable workflow can't be adapted, so I'm not sure the it properly tests the standalone variants. But I imagine whoever planned and approved this transition has already considered this issue.

`source_group(TREE` requires CMake 3.8
@gennaroprota gennaroprota merged commit db1ea76 into boostorg:develop Oct 24, 2025
58 of 59 checks passed
@Flamefire Flamefire deleted the patch-1 branch October 24, 2025 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants