Skip to content

Commit 7ce5a57

Browse files
[bitnami/external-dns] Fix bug with trailing comma in azure.json (#33951)
* fix: Fixed issue with trailing comma in azure.json Signed-off-by: Max Anderson <[email protected]> * Update CHANGELOG.md Signed-off-by: Bitnami Bot <[email protected]> * Update CHANGELOG.md Signed-off-by: Bitnami Bot <[email protected]> --------- Signed-off-by: Max Anderson <[email protected]> Signed-off-by: Bitnami Bot <[email protected]> Co-authored-by: Bitnami Bot <[email protected]>
1 parent eaa64a6 commit 7ce5a57

File tree

3 files changed

+35
-29
lines changed

3 files changed

+35
-29
lines changed

bitnami/external-dns/CHANGELOG.md

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,12 @@
11
# Changelog
22

3-
## 8.8.6 (2025-06-13)
3+
## 8.8.7 (2025-06-13)
44

5-
* [bitnami/external-dns] :zap: :arrow_up: Update dependency references ([#34426](https://github.com/bitnami/charts/pull/34426))
5+
* [bitnami/external-dns] Fix bug with trailing comma in azure.json ([#33951](https://github.com/bitnami/charts/pull/33951))
6+
7+
## <small>8.8.6 (2025-06-13)</small>
8+
9+
* [bitnami/external-dns] :zap: :arrow_up: Update dependency references (#34426) ([c9e97df](https://github.com/bitnami/charts/commit/c9e97dfcff4967cffeb898b628e253d6429e1a7d)), closes [#34426](https://github.com/bitnami/charts/issues/34426)
610

711
## <small>8.8.5 (2025-06-13)</small>
812

bitnami/external-dns/Chart.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,4 +30,4 @@ maintainers:
3030
name: external-dns
3131
sources:
3232
- https://github.com/bitnami/charts/tree/main/bitnami/external-dns
33-
version: 8.8.6
33+
version: 8.8.7

bitnami/external-dns/templates/_helpers.tpl

Lines changed: 28 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -168,33 +168,35 @@ region = {{ .Values.aws.region }}
168168
{{- end -}}
169169
{{- end -}}
170170

171+
171172
{{- define "external-dns.azure-credentials" -}}
172-
{
173-
{{- if .Values.azure.cloud }}
174-
"cloud": "{{ .Values.azure.cloud }}",
175-
{{- end }}
176-
{{- if .Values.azure.tenantId }}
177-
"tenantId": "{{ .Values.azure.tenantId }}",
178-
{{- end }}
179-
{{- if .Values.azure.subscriptionId }}
180-
"subscriptionId": "{{ .Values.azure.subscriptionId }}",
181-
{{- end }}
182-
"resourceGroup": "{{ .Values.azure.resourceGroup }}",
183-
{{- if not (or .Values.azure.useManagedIdentityExtension .Values.azure.useWorkloadIdentityExtension) }}
184-
"aadClientId": "{{ .Values.azure.aadClientId }}",
185-
"aadClientSecret": "{{ .Values.azure.aadClientSecret }}"
186-
{{- end }}
187-
{{- if .Values.azure.useWorkloadIdentityExtension }}
188-
"useWorkloadIdentityExtension": true,
189-
{{- end }}
190-
{{- if and .Values.azure.useManagedIdentityExtension .Values.azure.userAssignedIdentityID }}
191-
"useManagedIdentityExtension": true,
192-
"userAssignedIdentityID": "{{ .Values.azure.userAssignedIdentityID }}"
193-
{{- else if and .Values.azure.useManagedIdentityExtension (not .Values.azure.userAssignedIdentityID) }}
194-
"useManagedIdentityExtension": true
195-
{{- end }}
196-
}
197-
{{ end }}
173+
{{- $credentials := dict -}}
174+
{{- if .Values.azure.cloud -}}
175+
{{- $_ := set $credentials "cloud" .Values.azure.cloud -}}
176+
{{- end -}}
177+
{{- if .Values.azure.tenantId -}}
178+
{{- $_ := set $credentials "tenantId" .Values.azure.tenantId -}}
179+
{{- end -}}
180+
{{- if .Values.azure.subscriptionId -}}
181+
{{- $_ := set $credentials "subscriptionId" .Values.azure.subscriptionId -}}
182+
{{- end -}}
183+
{{- $_ := set $credentials "resourceGroup" .Values.azure.resourceGroup -}}
184+
{{- if not (or .Values.azure.useManagedIdentityExtension .Values.azure.useWorkloadIdentityExtension) -}}
185+
{{- $_ := set $credentials "aadClientId" .Values.azure.aadClientId -}}
186+
{{- $_ := set $credentials "aadClientSecret" .Values.azure.aadClientSecret -}}
187+
{{- end -}}
188+
{{- if .Values.azure.useWorkloadIdentityExtension -}}
189+
{{- $_ := set $credentials "useWorkloadIdentityExtension" true -}}
190+
{{- end -}}
191+
{{- if and .Values.azure.useManagedIdentityExtension .Values.azure.userAssignedIdentityID -}}
192+
{{- $_ := set $credentials "useManagedIdentityExtension" true -}}
193+
{{- $_ := set $credentials "userAssignedIdentityID" .Values.azure.userAssignedIdentityID -}}
194+
{{- else if and .Values.azure.useManagedIdentityExtension (not .Values.azure.userAssignedIdentityID) -}}
195+
{{- $_ := set $credentials "useManagedIdentityExtension" true -}}
196+
{{- end -}}
197+
{{- $credentials | toJson -}}
198+
{{- end -}}
199+
198200
{{- define "external-dns.oci-credentials" -}}
199201
{{- if .Values.oci.useWorkloadIdentity }}
200202
auth:

0 commit comments

Comments
 (0)