refactor(grit) rename gritql language ID to grit #858
Merged
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The official Grit extension registers the `grit` language ID. The Biome extension only recently registered the `gritql` language ID for the same file pattern. This is a conflict. For consistency within the VSCode ecosystem, it’s best to stick with one common language ID.
ematipico
reviewed
Nov 15, 2025
Member
ematipico
left a comment
ematipico
left a comment
There was a problem hiding this comment.
Instead of renaming, can you add it? There's a chance that this change will break the Biome language server unless we update core too (it will still break past versions of Biome language server)
Contributor
Author
|
Could you elaborate? A text document only has one language ID. |
Contributor
Author
|
I’m not familiar with Rust or the Biome code base, so please correct me if I’m wrong. But from this line, it looks like the Biome language server even expects the I think it only worked with the |
Member
|
Yeah you're right, you can discard my previous comment:) |
ematipico
approved these changes
Nov 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Rename the
gritqllanguage ID togritDescription
The official Grit extension registers the
gritlanguage ID. The Biome extension only recently registered thegritqllanguage ID for the same file pattern. This is a conflict. For consistency within the VSCode ecosystem, it’s best to stick with one common language ID.Related Issue
N/A
Checklist