`bevy::ecs::schedule::common_conditions::not` should support `SystemInput`

[lotus128]

What problem does this solve or what need does it fill?

bevy::ecs::schedule::common_conditions::not does not support SystemInput. ie, I cannot use systems with In params.

What solution would you like?

I would like bevy::ecs::schedule::common_conditions::not to support SystemInput so that I can use systems with In params.

What alternative(s) have you considered?

I implemented my own not condition.

[gwafotapa]

I'm not sure what you mean. How is run_if supposed to handle a SystemInput?

[lotus128]

I'm not sure what you mean. How is run_if supposed to handle a SystemInput?

Scheduling isn't the only uses case for Condition. I think it makes sense for not to be a method in the Condition trait alongside and.

I also think Condition doesn't belong in the ecs::scheduling module, but that's a separate issue.

[alice-i-cecile]

Scheduling isn't the only uses case for Condition.

That's news to me! Can you explain how you're using it?

[lotus128]

Scheduling isn't the only uses case for Condition.

That's news to me! Can you explain how you're using it?

My design didn't work out, but I was using Condition to evaluate triggers for a state machine; I was surprised to learn that not was absent from the Condition trait, despite it being a logical operator.