Skip to content

Commit 3926f02

Browse files
Make sequential_dispersed fn constant (#19659)
# Objective - Try to make more of `bevy_color` const now that we have const_float_arithmetic. ## Solution Fail abjectly, because of our heavy use of traits. I did find these functions though, so you can have a PR 🙃
1 parent 12ad747 commit 3926f02

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

crates/bevy_color/src/hsla.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ impl Hsla {
9292
/// // Palette with 5 distinct hues
9393
/// let palette = (0..5).map(Hsla::sequential_dispersed).collect::<Vec<_>>();
9494
/// ```
95-
pub fn sequential_dispersed(index: u32) -> Self {
95+
pub const fn sequential_dispersed(index: u32) -> Self {
9696
const FRAC_U32MAX_GOLDEN_RATIO: u32 = 2654435769; // (u32::MAX / Φ) rounded up
9797
const RATIO_360: f32 = 360.0 / u32::MAX as f32;
9898

crates/bevy_color/src/lcha.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,7 @@ impl Lcha {
9696
/// // Palette with 5 distinct hues
9797
/// let palette = (0..5).map(Lcha::sequential_dispersed).collect::<Vec<_>>();
9898
/// ```
99-
pub fn sequential_dispersed(index: u32) -> Self {
99+
pub const fn sequential_dispersed(index: u32) -> Self {
100100
const FRAC_U32MAX_GOLDEN_RATIO: u32 = 2654435769; // (u32::MAX / Φ) rounded up
101101
const RATIO_360: f32 = 360.0 / u32::MAX as f32;
102102

crates/bevy_color/src/oklcha.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ impl Oklcha {
9292
/// // Palette with 5 distinct hues
9393
/// let palette = (0..5).map(Oklcha::sequential_dispersed).collect::<Vec<_>>();
9494
/// ```
95-
pub fn sequential_dispersed(index: u32) -> Self {
95+
pub const fn sequential_dispersed(index: u32) -> Self {
9696
const FRAC_U32MAX_GOLDEN_RATIO: u32 = 2654435769; // (u32::MAX / Φ) rounded up
9797
const RATIO_360: f32 = 360.0 / u32::MAX as f32;
9898

0 commit comments

Comments
 (0)