Add AXISFLYINGH7MINI #822
Add AXISFLYINGH7MINI #822
Conversation
WalkthroughA new configuration header file for the AXISFLYINGH7MINI flight controller board has been introduced. This file defines the target MCU, board identifiers, sensor and peripheral enables, pin assignments, timer mappings, DMA options, UART/I2C/SPI assignments, default device settings, beeper configuration, and pin IO settings, centralizing all hardware-specific definitions. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Firmware
participant config.h
User->>Firmware: Select AXISFLYINGH7MINI target
Firmware->>config.h: Include board-specific config
config.h-->>Firmware: Provide MCU, sensors, pin mappings, peripherals
Firmware-->>User: Initializes board using provided configuration
Possibly related PRs
Suggested reviewers
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (3)
configs/AXISFLYINGH7MINI/config.h (3)
68-71: Document I2C bus usage.Add inline comments indicating which sensors use I2C1 vs. I2C2 (e.g., barometer vs. external magnetometer) to aid future maintainers.
130-133: Reconsider default DSHOT implementation.Hardware DSHOT support is available on STM32H7—using bitbang by default may underutilize built-in timers. Consider defaulting to hardware DSHOT or document why bitbang is preferred.
143-143: Add trailing newline.Ensure the file ends with a newline to comply with POSIX text file conventions.
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
configs/AXISFLYINGH7MINI/config.h(1 hunks)
🧰 Additional context used
🧠 Learnings (1)
configs/AXISFLYINGH7MINI/config.h (1)
Learnt from: haslinghuis
PR: betaflight/config#0
File: :0-0
Timestamp: 2025-06-02T16:16:20.197Z
Learning: In STM32F405-based flight controller configurations, timer pin mappings must be carefully analyzed for DMA stream conflicts, especially between motor timers, LED strip timers, and SPI DMA assignments. Changes to TIMER_PIN_MAPPING should include verification that all required peripherals (motors, LED strip, blackbox SPI) can coexist without DMA conflicts.
🔇 Additional comments (8)
configs/AXISFLYINGH7MINI/config.h (8)
1-20: Skip license header review.Standard GPL header appears consistent with other Betaflight configs.
22-28: Verify BOARD_NAME and MANUFACTURER_ID formatting.Ensure these macros use the same literal style (e.g., quoted strings) as existing board configs for consistency in build scripts and UI display.
39-50: Validate motor & LED pin mappings against schematic.Double-check that
MOTOR1_PIN–MOTOR8_PINandLED_STRIP_PINassignments match the physical PCB silk-screen and that no GPIO remapping conflicts exist.
52-67: Missing UART5 pin assignments?You specify TX/RX for USART1–4 and UART6–8 but skip USART5. Verify if USART5 is unavailable on STM32H743 or if its pins were overlooked.
103-112: Validate timer pin mapping against DMA streams.Per retrieved learnings, confirm that the timers for motors (channels 0–7) and the LED strip (channel 8) do not share DMA streams used by SPI (flash, gyros, OSD) to avoid runtime collisions.
114-117: Confirm ADC DMA channel selections.Ensure
ADC1_DMA_OPT = 9,ADC2_DMA_OPT = 10, andADC3_DMA_OPT = 11correspond to the correct stream/channel mapping on STM32H743 so ADC sampling isn’t lost.
135-138: Verify PINIO box IDs.Confirm that
PINIO1_BOX = 40andPINIO2_BOX = 41align with the Betaflight UI/config schema for these configurable pins.
139-142: SPI instance assignments look correct.
GYRO_1_SPI_INSTANCE = SPI1(PA5),GYRO_2_SPI_INSTANCE = SPI4(PE12),FLASH_SPI_INSTANCE = SPI3(PB3), andMAX7456_SPI_INSTANCE = SPI2(PB13) align with the SCK pin definitions.
Summary by CodeRabbit