Skip to content

Conversation

@lzaugg
Copy link
Contributor

@lzaugg lzaugg commented Oct 31, 2025

  • use pushd/popd
  • fix path of referenced zip file

@lzaugg lzaugg changed the title Fix file path for level 5 Fix file path in Level 5 Oct 31, 2025
@cloudlena
Copy link
Member

Thanks, @lzaugg!

I don't see why this change is necessary. Can't the user run all the AWS commands from the level-5/function folder and remain in there?

So far, we've deliberately refrained from using pushd and popd to not confuse users who don't know these commands with having to learn new things that aren't related to serverless.

@lzaugg
Copy link
Contributor Author

lzaugg commented Dec 1, 2025

I don't see why this change is necessary. Can't the user run all the AWS commands from the level-5/function folder and remain in there?

Of course, but it was confusing for me to work like this up to level-4 and suddenly change the way of how to build and reference the zip file.

So far, we've deliberately refrained from using pushd and popd to not confuse users who don't know these commands with having to learn new things that aren't related to serverless.

If you're aiming for a consistent way without pushd/popd I'm totally fine, just wanted to do the same (but obviously in the wrong direction 😅 ). PR can be skipped then.

@cloudlena cloudlena merged commit a6f0e33 into bespinian:main Dec 1, 2025
@cloudlena
Copy link
Member

cloudlena commented Dec 1, 2025

Ah, I get it. I wasn't aware of that inconsistency, but you're absolutely right 😅
Thanks for the clarification and the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants