Skip to content

Commit 7ef0c6b

Browse files
authored
Merge pull request #4 from benfoxall/upgrade-node
Upgrade this application to run on newer versions of node
2 parents 8cbdff4 + 6ba1599 commit 7ef0c6b

File tree

4 files changed

+10
-2
lines changed

4 files changed

+10
-2
lines changed

.devcontainer/Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# See here for image contents: https://github.com/microsoft/vscode-dev-containers/tree/v0.145.1/containers/typescript-node/.devcontainer/base.Dockerfile
22

33
# [Choice] Node.js version: 14, 12, 10
4-
ARG VARIANT="14-buster"
4+
ARG VARIANT="16-buster"
55
FROM mcr.microsoft.com/vscode/devcontainers/typescript-node:0-${VARIANT}
66

77
# [Optional] Uncomment this section to install additional OS packages.

.devcontainer/devcontainer.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
"build": {
44
"dockerfile": "Dockerfile",
55
// Update 'VARIANT' to pick a Node version: 10, 12, 14
6-
"args": { "VARIANT": "14" }
6+
"args": { "VARIANT": "16" }
77
},
88

99
// Set *default* container specific settings.json values on container create.

.github/workflows/deploy.yml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,11 @@ jobs:
2727
restore-keys: |
2828
${{ runner.os }}-node
2929
30+
- name: Set up Node.js 16
31+
uses: actions/setup-node@v2
32+
with:
33+
node-version: 16
34+
3035
- name: Install and Build 🔧
3136
run: |
3237
npm ci

package.json

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,5 +35,8 @@
3535
"snowpack": "^2.15.1",
3636
"typescript": "^4.0.0",
3737
"y-protocols": "^1.0.1"
38+
},
39+
"engines": {
40+
"node": ">=16.0.0"
3841
}
3942
}

0 commit comments

Comments
 (0)