Skip to content
This repository was archived by the owner on Oct 12, 2022. It is now read-only.

Commit 231fc41

Browse files
committed
Bump minimum Android API level to 26 (8.0+).
1 parent 2b72967 commit 231fc41

File tree

1 file changed

+9
-2
lines changed

1 file changed

+9
-2
lines changed

main.sh

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,14 +34,21 @@ function build_one_abi() {
3434
PYTHON_VERSION="$2"
3535
COMPRESS_LEVEL="$3"
3636

37-
# Using ANDROID_API_LEVEL=21 for two reasons:
37+
# Using ANDROID_API_LEVEL=26 (i.e., Android 8.0+) for two reasons:
3838
#
3939
# - >= 21 gives us a `localeconv` libc function (admittedly a
4040
# non-working one), which makes compiling (well, linking) Python
4141
# easier.
4242
#
4343
# - 64-bit architectures only start existing at API level 21.
44-
ANDROID_API_LEVEL=21
44+
#
45+
# - < 26 has a limit on the number of local references. This
46+
# can cause crashes for some code.
47+
#
48+
# - As of June 2022, Android 8.0+ devices comprise ~83.5% of all
49+
# devices seen in the wild.
50+
ANDROID_API_LEVEL=26
51+
4552
# Compute the compiler name & binutils prefix name. See also:
4653
# https://developer.android.com/ndk/guides/other_build_systems
4754

0 commit comments

Comments
 (0)