Skip to content

Restrict the kind query to start anchor #1388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −1
Open

Restrict the kind query to start anchor #1388

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion unused_deps/unused_deps.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -354,7 +354,7 @@ func main() {
}
queryCmd = append(queryCmd, blazeFlags...)
queryCmd = append(
queryCmd, fmt.Sprintf("kind('(kt|java|android)_*', %s)", strings.Join(targetPatterns, " + ")))
queryCmd, fmt.Sprintf("kind('^(kt|java|android)_*', %s)", strings.Join(targetPatterns, " + ")))
Copy link
Collaborator

@AnnaSvalova AnnaSvalova Nov 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the line 365 be updated as well? To match the real command.

Would be nice to have tests as well, but it seems that this file is not covered by any tests =/ Therefore, this is a non-blocking wish.

Copy link
Contributor Author

@fzakaria fzakaria Nov 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the log message?
It's probably fine as is tbh.

Copy link
Collaborator

@AnnaSvalova AnnaSvalova Nov 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe.. I'd keep everything aligned, but this doesn't really affect user experience.


log.Printf("running: %s %s", *buildTool, strings.Join(queryCmd, " "))
queryOut, err := cmdWithStderr(*buildTool, queryCmd...).Output()
Expand Down