Skip to content

[buildifier] Warn (and exit nonzero) if --lint=fix and there are unfixable lints #1418

@thejcannon

Description

@thejcannon

Unfortunately, because -lint=fix exits zero (even if there are unfixable errors), that means I don't have any confidence that -lint=fix doesn't require a subsequent -lint=warn (which means I'm having to run buildifier twice.

Ideally, -lint=fix would:

  • Fix fixable lints
  • Warn/exit nonzero the non-fixable ones

(Alternatively could be a new lint value like fix-and-warn)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions