Turning off Sleep Mode clears manual_control

[ejpenney]

Version information:

Adaptive Lighting: 1.1.0
Home Assistant: 2022.10.0

Description:

Disabling Sleep Mode clears the manual_control attribute. I don't think this is expected behavior.

Steps to reproduce:

1. Turn on target light

service: light.turn_on
  entity_id: light.family_room

2. Enable Sleep Mode

service: switch.turn_on
  entity_id: switch.adaptive_lighting_sleep_mode_family_room

3. Run adaptive_lighting.manual_control

service: adaptive_lighting.manual_control
  data:
    entity_id: switch.adaptive_lighting_family_room
    lights: light.family_room_overhead
    manual_control: True

4. Disable Sleep Mode

service: switch.turn_off
  entity_id: switch.adaptive_lighting_sleep_mode_family_room

Expected result: Since manual_control is set for light.family_room_overhead it should remain in its current state and manual_control should retain the value ['light.family_room_overhead']
Actual result: switch.adaptive_lighting_family_room attribute manual_control is cleared, and set to []

Let me know if there's anything else I can provide for this.

[th3w1zard1]

This absolutely is expected behavior. Why would you want to toggle the sleep switch, if you didn't want the integration to perform some sort of adapt?

[ejpenney]

I absolutely agree that toggling an Adaptive Lighting switch should have Adaptive Lighting act on entities it is currently controlling.

I do not think Adaptive Lighting should act on devices currently in the manual control list. I definitely don't think it should reset the manually controlled devices list unless the lights are turned off or adaptive_lighting.set_manual_control is called.

Again, I do think toggling a switch should act on devices. Just not ones we've explicitly indicated are currently being manually controlled.

[th3w1zard1]

Oh duh, you probably wanted to toggle the sleep switch for the other non controlled lights. This is a great idea! I'd love to see this happen.

For now what you can do is create a separate config for each of your light groups so you'll have separate switches for each, this is how most of us get around that problem.

[ejpenney]

Yeah, I don't feel like you quite understood the issue I'm seeing. According to the AL documentation:

Adaptive Lighting is designed to automatically detect when you or another source (e.g., automation) manually changes light settings 🕹️. When this occurs, the affected light is marked as "manually controlled," and Adaptive Lighting will not make further adjustments until the light is turned off and back on or reset using the adaptive_lighting.set_manual_control service call. This feature is available when take_over_control is enabled.

Emphasis mine.

The issue is, according to the documentation, bulbs in manual_control should not be adapted by AL, but are being modified by AL if sleep mode is toggled to on. There are any number of ways to work around this bug, but according to the definition I'm reading, it's a bug. Unless manual_control doesn't really mean that AL will leave these bulbs alone until adaptive_lighting.set_manual_control is called. In which case the bug is with the documentation, and a more correct definition should be provided.

Either way, I'm convinced this is a bug...

[basnijholt]

Actually, the docs are not correct here.

The manual control will be reset when:

• turn on light on and off
• turning adaptive_lighting switch on and off
• turning sleep switch on an off
• when calling set_manual_control
• when calling change_switch settings