🐛 fix(core): Cannot build after upgrade 19.2.0 to 19.3.0 (#1750)

* Create PR for #1749

* add back format cjs

* format

* revert back changed in core/index.ts

* fix(core): fix doc app

* use release mode for snapshots

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Magdalena Marinkov <[email protected]>
Co-authored-by: Marco Zirkenbach <[email protected]>
Co-authored-by: Gery Hirschfeld <[email protected]>

Author: 4 people

.github/workflows/pr-comment.yml

@@ -84,6 +84,8 @@ jobs:
 
       - name: Build
         run: npx nx run-many -t build --projects=tag:scope:release
+        env:
+          BAL_DS_RELEASE: true
 
       - name: Pre-Publish
         run: npx nx run pre-publish

packages/core/src/components.d.ts

@@ -1124,39 +1124,6 @@ export namespace Components {
          */
         "space": BalProps.BalDividerSpace;
     }
-    interface BalDocApp {
-        /**
-          * Disables all animation inside the bal-app. Can be used for simplify e2e testing.
-          * @default true
-         */
-        "animated": boolean;
-        "language"?: string;
-        /**
-          * @default ''
-         */
-        "logComponents": string;
-        /**
-          * @default true
-         */
-        "logCustom": boolean;
-        /**
-          * @default true
-         */
-        "logEvents": boolean;
-        /**
-          * @default true
-         */
-        "logLifecycle": boolean;
-        /**
-          * @default true
-         */
-        "logRender": boolean;
-        "region"?: string;
-        /**
-          * @default false
-         */
-        "stickyFooter": boolean;
-    }
     interface BalDropdown {
         /**
           * Indicates whether the value of the control can be automatically completed by the browser.
@@ -4930,12 +4897,6 @@ declare global {
         prototype: HTMLBalDividerElement;
         new (): HTMLBalDividerElement;
     };
-    interface HTMLBalDocAppElement extends Components.BalDocApp, HTMLStencilElement {
-    }
-    var HTMLBalDocAppElement: {
-        prototype: HTMLBalDocAppElement;
-        new (): HTMLBalDocAppElement;
-    };
     interface HTMLBalDropdownElementEventMap {
         "balChange": BalEvents.BalDropdownChangeDetail;
         "balFocus": BalEvents.BalDropdownFocusDetail;
@@ -5917,7 +5878,6 @@ declare global {
         "bal-date-calendar": HTMLBalDateCalendarElement;
         "bal-date-calendar-cell": HTMLBalDateCalendarCellElement;
         "bal-divider": HTMLBalDividerElement;
-        "bal-doc-app": HTMLBalDocAppElement;
         "bal-dropdown": HTMLBalDropdownElement;
         "bal-field": HTMLBalFieldElement;
         "bal-field-control": HTMLBalFieldControlElement;
@@ -7143,39 +7103,6 @@ declare namespace LocalJSX {
          */
         "space"?: BalProps.BalDividerSpace;
     }
-    interface BalDocApp {
-        /**
-          * Disables all animation inside the bal-app. Can be used for simplify e2e testing.
-          * @default true
-         */
-        "animated"?: boolean;
-        "language"?: string;
-        /**
-          * @default ''
-         */
-        "logComponents"?: string;
-        /**
-          * @default true
-         */
-        "logCustom"?: boolean;
-        /**
-          * @default true
-         */
-        "logEvents"?: boolean;
-        /**
-          * @default true
-         */
-        "logLifecycle"?: boolean;
-        /**
-          * @default true
-         */
-        "logRender"?: boolean;
-        "region"?: string;
-        /**
-          * @default false
-         */
-        "stickyFooter"?: boolean;
-    }
     interface BalDropdown {
         /**
           * Indicates whether the value of the control can be automatically completed by the browser.
@@ -10496,7 +10423,6 @@ declare namespace LocalJSX {
         "bal-date-calendar": BalDateCalendar;
         "bal-date-calendar-cell": BalDateCalendarCell;
         "bal-divider": BalDivider;
-        "bal-doc-app": BalDocApp;
         "bal-dropdown": BalDropdown;
         "bal-field": BalField;
         "bal-field-control": BalFieldControl;
@@ -10620,7 +10546,6 @@ declare module "@stencil/core" {
             "bal-date-calendar": LocalJSX.BalDateCalendar & JSXBase.HTMLAttributes<HTMLBalDateCalendarElement>;
             "bal-date-calendar-cell": LocalJSX.BalDateCalendarCell & JSXBase.HTMLAttributes<HTMLBalDateCalendarCellElement>;
             "bal-divider": LocalJSX.BalDivider & JSXBase.HTMLAttributes<HTMLBalDividerElement>;
-            "bal-doc-app": LocalJSX.BalDocApp & JSXBase.HTMLAttributes<HTMLBalDocAppElement>;
             "bal-dropdown": LocalJSX.BalDropdown & JSXBase.HTMLAttributes<HTMLBalDropdownElement>;
             "bal-field": LocalJSX.BalField & JSXBase.HTMLAttributes<HTMLBalFieldElement>;
             "bal-field-control": LocalJSX.BalFieldControl & JSXBase.HTMLAttributes<HTMLBalFieldControlElement>;

packages/core/src/components/docs/bal-doc-app/bal-doc-app.tsx

@@ -1,9 +1,9 @@
-import { Component, Host, h, Prop, ComponentInterface } from '@stencil/core'
 import * as balIcons from '@baloise/ds-icons'
-import { updateBalIcons } from '../../../utils/config'
+import { Component, ComponentInterface, h, Host, Prop } from '@stencil/core'
+import globalScript from '../../../global'
 import { balBrowser } from '../../../utils/browser'
+import { updateBalIcons } from '../../../utils/config'
 import { BalLogger } from '../../../utils/log'
-import globalScript from '../../../global'
 
 /**
  * @internal

packages/core/src/index.ts

@@ -29,7 +29,7 @@ export {
 /**
  * Components
  */
-export * from './components'
+export { Components, JSX } from './components'
 
 /**
  * Types

packages/core/stencil.config.ts

@@ -3,10 +3,10 @@ import { sass } from '@stencil/sass'
 import fg from 'fast-glob'
 import { join, parse, resolve } from 'path'
 
+import { webOutputTarget } from '@baloise/output-target-web'
+import { CustomDocumentationGenerator } from './config/doc-output-target'
 import { AngularGenerator, AngularModuleGenerator } from './config/stencil.bindings.angular'
 import { ReactGenerator } from './config/stencil.bindings.react'
-import { CustomDocumentationGenerator } from './config/doc-output-target'
-import { webOutputTarget } from '@baloise/output-target-web'
 
 const IS_BAL_DS_RELEASE = process.env.BAL_DS_RELEASE === 'true'
 const IS_BAL_DOCUMENTATION = process.env.BAL_DOCUMENTATION === 'true'