Upgrade intel gemm conv tests #103
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
June 19, 2018 09:00
…ments Update Intel code to work better in automated testing environments by allowing one to specify on the command line the type of matrix to test and additionally print output in a machine readable CSV format. We also provide some basic bug fixes to the code as well. Signed-off-by: Geoffrey Blake ([email protected])
Signed-off-by: Geoffrey Blake ([email protected])
WilliamTambellini
approved these changes
Jun 20, 2018
WilliamTambellini
left a comment
WilliamTambellini
left a comment
There was a problem hiding this comment.
Thank you : the use of device 1 in the run_mkl_xgemm sh scripts were confusing for local run.
csv output is also welcome for quick spreadsheet reporting.
Signed-off-by: Geoffrey Blake ([email protected])
Author
|
Anyone willing to review this pull request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request upgrades the x86 xGEMM tests with a new library bindingto the OpenBLAS library to test and compare with the existing MKL library. It also upgrades how the tests are instantiated with new command line arguments to specify individual matrices, or the built in tests, and # of threads.
Output from GEMM and Convolution tests now output in a machine readable CSV format instead of just human readable text.
These changes are particularly useful for inserting Deepbench into automated testing infrastructures to get finer control and allow automatic parsing of test results. This is the dual of the Arm test upgrades in pull request #102 .